From: Borislav Petkov <bp@alien8.de>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Kuo-Lang Tseng <kuo-lang.tsenng@intel.com>,
Babu Moger <babu.moger@amd.com>, H Peter Anvin <hpa@zytor.com>,
x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/resctrl: Enable user to view thread or core throttling mode
Date: Fri, 21 Aug 2020 15:13:17 +0200 [thread overview]
Message-ID: <20200821131306.GH12181@zn.tnic> (raw)
In-Reply-To: <1594921994-66192-3-git-send-email-fenghua.yu@intel.com>
On Thu, Jul 16, 2020 at 10:53:14AM -0700, Fenghua Yu wrote:
> struct rdt_membw {
> - u32 max_delay;
> - u32 min_bw;
> - u32 bw_gran;
> - u32 delay_linear;
> - bool mba_sc;
> - u32 *mb_map;
> + u32 max_delay;
> + u32 min_bw;
> + u32 bw_gran;
> + u32 delay_linear;
> + enum membw_throttle_mode arch_throttle_mode;
I guess "arch" is implicit so you can
s/arch_throttle_mode/throttle_mode/g
...
> +static struct rftype *rdtgroup_rftype_by_name(const char *name)
That function name needs a verb.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-08-21 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:53 [PATCH 0/2] " Fenghua Yu
2020-07-16 17:53 ` [PATCH 1/2] x86/resctrl: Enumerate per-thread MBA Fenghua Yu
2020-07-16 17:53 ` [PATCH 2/2] x86/resctrl: Enable user to view thread or core throttling mode Fenghua Yu
2020-08-21 13:13 ` Borislav Petkov [this message]
2020-08-21 17:11 ` Fenghua Yu
2020-08-19 0:38 ` [PATCH 0/2] " Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821131306.GH12181@zn.tnic \
--to=bp@alien8.de \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kuo-lang.tsenng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®