From: Clint Sbisa <csbisa@amazon.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Jiri Kosina <trivial@kernel.org>
Cc: Clint Sbisa <csbisa@amazon.com>,
Benjamin Herrenschmidt <benh@amazon.com>,
Ali Saidi <alisaidi@amazon.com>,
David Woodhouse <dwmw@amazon.co.uk>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] PCI: Trivial comment fixup for PCI mmap ifdefs
Date: Fri, 21 Aug 2020 15:51:21 +0000 [thread overview]
Message-ID: <20200821155121.nzxjeeoze4h5pone@amazon.com> (raw)
The else/endif comments for pci_{create,remove}_resource_files were
not updated in commit f719582435afe9c7985206e42d804ea6aa315d33 ("PCI:
Add pci_mmap_resource_range() and use it for ARM64").
Signed-off-by: Clint Sbisa <csbisa@amazon.com>
---
drivers/pci/pci-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 6d78df981d41..cfc67b208616 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1196,10 +1196,10 @@ static int pci_create_resource_files(struct pci_dev *pdev)
}
return 0;
}
-#else /* !HAVE_PCI_MMAP */
+#else /* ! (defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)) */
int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }
void __weak pci_remove_resource_files(struct pci_dev *dev) { return; }
-#endif /* HAVE_PCI_MMAP */
+#endif /* defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE) */
/**
* pci_write_rom - used to enable access to the PCI ROM display
--
2.23.3
next reply other threads:[~2020-08-21 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 15:51 Clint Sbisa [this message]
2020-09-17 17:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821155121.nzxjeeoze4h5pone@amazon.com \
--to=csbisa@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=bhelgaas@google.com \
--cc=dwmw@amazon.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®