From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8908AC433E3 for ; Sun, 23 Aug 2020 14:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70CCD20706 for ; Sun, 23 Aug 2020 14:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727833AbgHWOg0 (ORCPT ); Sun, 23 Aug 2020 10:36:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40512 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgHWOgY (ORCPT ); Sun, 23 Aug 2020 10:36:24 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k9r6A-00BN8J-45; Sun, 23 Aug 2020 16:35:54 +0200 Date: Sun, 23 Aug 2020 16:35:54 +0200 From: Andrew Lunn To: Dinghao Liu Cc: kjlu@umn.edu, "David S. Miller" , Jakub Kicinski , Heiko Stuebner , Caesar Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe Message-ID: <20200823143554.GE2588906@lunn.ch> References: <20200823085650.912-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200823085650.912-1-dinghao.liu@zju.edu.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 23, 2020 at 04:56:47PM +0800, Dinghao Liu wrote: > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu Reviewed-by: Andrew Lunn Andrew