From: Sumera Priyadarsini <sylphrenadin@gmail.com>
To: davem@davemloft.net
Cc: Julia.Lawall@lip6.fr, andrew@lunn.ch, sean.wang@mediatek.com,
vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Sumera Priyadarsini <sylphrenadin@gmail.com>
Subject: [PATCH V2] net: dsa: Add of_node_put() before break statement
Date: Mon, 24 Aug 2020 00:20:56 +0530 [thread overview]
Message-ID: <20200823185056.16641-1-sylphrenadin@gmail.com> (raw)
Every iteration of for_each_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.
Fix a potential memory leak in mt7530.c by inserting of_node_put()
before the break statement.
Issue found with Coccinelle.
---
Changes in v2:
Add another of_node_put() in for_each_child_of_node() as pointed
out by Andrew.
---
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/net/dsa/mt7530.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 8dcb8a49ab67..e81198a65c26 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1327,6 +1327,7 @@ mt7530_setup(struct dsa_switch *ds)
if (phy_node->parent == priv->dev->of_node->parent) {
ret = of_get_phy_mode(mac_np, &interface);
if (ret && ret != -ENODEV)
+ of_node_put(mac_np)
return ret;
id = of_mdio_parse_addr(ds->dev, phy_node);
if (id == 0)
@@ -1334,6 +1335,7 @@ mt7530_setup(struct dsa_switch *ds)
if (id == 4)
priv->p5_intf_sel = P5_INTF_SEL_PHY_P4;
}
+ of_node_put(mac_np);
of_node_put(phy_node);
break;
}
--
2.17.1
next reply other threads:[~2020-08-23 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 18:50 Sumera Priyadarsini [this message]
2020-08-23 19:13 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823185056.16641-1-sylphrenadin@gmail.com \
--to=sylphrenadin@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®