From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0888AC433DF for ; Mon, 24 Aug 2020 12:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC3BB20706 for ; Mon, 24 Aug 2020 12:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727968AbgHXM73 (ORCPT ); Mon, 24 Aug 2020 08:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgHXM72 (ORCPT ); Mon, 24 Aug 2020 08:59:28 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8ACC061573; Mon, 24 Aug 2020 05:59:28 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 262F01281D748; Mon, 24 Aug 2020 05:42:40 -0700 (PDT) Date: Mon, 24 Aug 2020 05:59:25 -0700 (PDT) Message-Id: <20200824.055925.508725099038824391.davem@davemloft.net> To: dinghao.liu@zju.edu.cn Cc: kjlu@umn.edu, f.fainelli@gmail.com, kuba@kernel.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: systemport: Fix memleak in bcm_sysport_probe From: David Miller In-Reply-To: <20200824055831.26745-1-dinghao.liu@zju.edu.cn> References: <20200824055831.26745-1-dinghao.liu@zju.edu.cn> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Aug 2020 05:42:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu Date: Mon, 24 Aug 2020 13:58:31 +0800 > When devm_kcalloc() fails, dev should be freed just > like what we've done in the subsequent error paths. > > Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX rings") > Signed-off-by: Dinghao Liu Applied and queued up for -stable, thanks.