From: David Miller <davem@davemloft.net>
To: christophe.jaillet@wanadoo.fr
Cc: dave@thedillows.org, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API
Date: Mon, 24 Aug 2020 17:33:33 -0700 (PDT) [thread overview]
Message-ID: <20200824.173333.548043755025064224.davem@davemloft.net> (raw)
In-Reply-To: <20200823061150.162135-1-christophe.jaillet@wanadoo.fr>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sun, 23 Aug 2020 08:11:50 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> When memory is allocated in 'typhoon_init_one()' GFP_KERNEL can be used
> because it is a probe function and no lock is acquired.
>
> When memory is allocated in 'typhoon_download_firmware()', GFP_ATOMIC
> must be used because it can be called from a .ndo_tx_timeout function.
> So this function can be called with the 'netif_tx_lock' acquired.
> The call chain is:
> --> typhoon_tx_timeout (.ndo_tx_timeout function)
> --> typhoon_start_runtime
> --> typhoon_download_firmware
>
> While at is, update some comments accordingly.
...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
prev parent reply other threads:[~2020-08-25 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 6:11 Christophe JAILLET
2020-08-23 20:31 ` David Dillow
2020-08-25 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824.173333.548043755025064224.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave@thedillows.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®