mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@suse.de>,
	"Chen, Rong A" <rong.a.chen@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"lkp@lists.01.org" <lkp@lists.01.org>,
	Mel Gorman <mgorman@suse.com>
Subject: Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression
Date: Mon, 24 Aug 2020 23:48:18 +0800	[thread overview]
Message-ID: <20200824154818.GB56944@shbuild999.sh.intel.com> (raw)
In-Reply-To: <6e996ad05e434a6fb13f069ee72b876b@intel.com>

On Mon, Aug 24, 2020 at 11:38:53PM +0800, Luck, Tony wrote:
> > Yes, that's what we suspected. And I just did another try to force the
> > percpu mce structure aligned. And the regression seems to be gone (reduced
> > from 14.1% to 2%), which further proved it.
> 
> I wonder whether it would be useful for bisection of performance issues
> for you to change the global definition of DEFINE_PER_CPU() to make
> all per CPU definitions aligned. Just like you switch compiler flags to make
> all functions aligned.

Thanks for the hint! This will definitely help tracking strange performance
changes like this, as a general debug mthod.

Thanks,
Feng

> 
> -Tony

  reply	other threads:[~2020-08-24 15:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 11:44 kernel test robot
2020-04-25 13:01 ` Borislav Petkov
2020-08-18  8:29   ` [LKP] " Feng Tang
2020-08-18 20:06     ` Luck, Tony
2020-08-19  2:04       ` Feng Tang
2020-08-19  2:23         ` Luck, Tony
2020-08-19  3:04           ` Feng Tang
2020-08-19  3:15           ` Feng Tang
2020-08-21  2:02         ` Feng Tang
2020-08-24 15:14           ` Borislav Petkov
2020-08-24 15:33             ` Feng Tang
2020-08-24 15:38               ` Luck, Tony
2020-08-24 15:48                 ` Feng Tang [this message]
2020-08-24 16:12               ` Borislav Petkov
2020-08-24 16:56                 ` Mel Gorman
2020-08-25  6:49                   ` Feng Tang
2020-08-25  6:23                 ` Feng Tang
2020-08-25 16:44                   ` Luck, Tony
2020-08-26  1:45                     ` Feng Tang
2020-08-28 17:48                   ` Borislav Petkov
2020-08-31  2:16                     ` Feng Tang
2020-08-31  7:56                       ` Mel Gorman
2020-08-31  8:23                         ` Feng Tang
2020-08-31  8:55                           ` Mel Gorman
2020-08-31 12:53                             ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824154818.GB56944@shbuild999.sh.intel.com \
    --to=feng.tang@intel.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=mgorman@suse.com \
    --cc=rong.a.chen@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®