From: Greg KH <greg@kroah.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: stable@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Sajida Bhanu <sbhanu@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH - stable v5.4 and v5.7] opp: Enable resources again if they were disabled earlier
Date: Mon, 24 Aug 2020 18:10:49 +0200 [thread overview]
Message-ID: <20200824161049.GE435319@kroah.com> (raw)
In-Reply-To: <31f315cf2b0c4afd60b07b7121058dcaa6e4afa1.1598260882.git.viresh.kumar@linaro.org>
On Mon, Aug 24, 2020 at 02:52:23PM +0530, Viresh Kumar wrote:
> From: Rajendra Nayak <rnayak@codeaurora.org>
>
> commit a4501bac0e553bed117b7e1b166d49731caf7260 upstream.
>
> dev_pm_opp_set_rate() can now be called with freq = 0 in order
> to either drop performance or bandwidth votes or to disable
> regulators on platforms which support them.
>
> In such cases, a subsequent call to dev_pm_opp_set_rate() with
> the same frequency ends up returning early because 'old_freq == freq'
>
> Instead make it fall through and put back the dropped performance
> and bandwidth votes and/or enable back the regulators.
>
> Cc: v5.3+ <stable@vger.kernel.org> # v5.3+
> Fixes: cd7ea582866f ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
> Reported-by: Sajida Bhanu <sbhanu@codeaurora.org>
> Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> [ Viresh: Don't skip clk_set_rate() and massaged changelog ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> [ Viresh: Updated the patch to apply to v5.4 ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/opp/core.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
This too is already in the 5.7 and 5.4 queues, why add it again?
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-24 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:22 Viresh Kumar
2020-08-24 16:10 ` Greg KH [this message]
2020-08-25 4:25 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824161049.GE435319@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rnayak@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®