From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01FFC433E1 for ; Mon, 24 Aug 2020 16:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94C6E20738 for ; Mon, 24 Aug 2020 16:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598286766; bh=JWw68BuVJ7xfLohloWh48lvCAxIed5C9r3jJcJyxoFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KNeuKSYtJ2N/LrzJBANCnIw2zfk86ZV7h3jydYjEchmMJE2xCTFKP7lbblJtgEegR htjNHwn9pHat4ZTn+RkBXyPmdJSGctg9yo4YMGb7kzsnUzbdgApjSrgx5c32Rz9tBC bz0+I36l7XVcFIqz3D/qbmha/TIxKGZzNP8ArTYE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728213AbgHXQcg (ORCPT ); Mon, 24 Aug 2020 12:32:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:35014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728145AbgHXQcQ (ORCPT ); Mon, 24 Aug 2020 12:32:16 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E8902067C; Mon, 24 Aug 2020 16:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598286735; bh=JWw68BuVJ7xfLohloWh48lvCAxIed5C9r3jJcJyxoFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y+9T9DDdaJQxrm+zCaoyAUMyqLdeyuK0qOA+cQzh+mMxS41Bv8U+rmlEuVsrkVvGw v9T2hfFFPIeGCAOD2/nhQS5SvGDVtpEeC13I06nqHVJYs1m8Q2JYslDw/NiOUG9GRB UkP89VXdr0z4pAX8KrTtN8anYDfYxYgeaWa6l96g= Date: Mon, 24 Aug 2020 17:32:09 +0100 From: Will Deacon To: Florian Fainelli Cc: Greg KH , Will Deacon , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Catalin Marinas , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Mark Rutland , Mark Brown , Kristina Martsenko , Sami Tolvanen , Andrew Jones , Ard Biesheuvel , Nick Desaulniers , Fangrui Song , open list , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" Subject: Re: [PATCH stable v4.9 v2] arm64: entry: Place an SB sequence following an ERET instruction Message-ID: <20200824163208.GA25316@willie-the-truck> References: <20200709195034.15185-1-f.fainelli@gmail.com> <20200720130411.GB494210@kroah.com> <9c29080e-8b3a-571c-3296-e0487fa473fa@gmail.com> <20200807131429.GB664450@kroah.com> <20200821160316.GE21517@willie-the-truck> <7480435b-355d-b9f7-3a42-b72a9c4b6f63@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7480435b-355d-b9f7-3a42-b72a9c4b6f63@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On Fri, Aug 21, 2020 at 10:16:23AM -0700, Florian Fainelli wrote: > On 8/21/20 9:03 AM, Will Deacon wrote: > > On Fri, Aug 07, 2020 at 03:14:29PM +0200, Greg KH wrote: > >> On Thu, Aug 06, 2020 at 01:00:54PM -0700, Florian Fainelli wrote: > >>> Greg, did you have a chance to queue those changes for 4.9, 4.14 and 4.19? > >>> > >>> https://lore.kernel.org/linux-arm-kernel/20200720182538.13304-1-f.fainelli@gmail.com/ > >>> https://lore.kernel.org/linux-arm-kernel/20200720182937.14099-1-f.fainelli@gmail.com/ > >>> https://lore.kernel.org/linux-arm-kernel/20200709195034.15185-1-f.fainelli@gmail.com/ > >> > >> Nope, I was waiting for Will's "ack" for these. > > > > This patch doesn't even build for me (the 'sb' macro is not defined in 4.9), > > and I really wonder why we bother backporting it at all. Nobody's ever shown > > it to be a problem in practice, and it's clear that this is just being > > submitted to tick a box rather than anything else (otherwise it would build, > > right?). > > Doh, I completely missed submitting the patch this depended on that's > why I did not notice the build failure locally, sorry about that, what a > shame. > > Would not be the same "tick a box" argument be used against your > original submission then? Sure, I have not been able to demonstrate in > real life this was a problem, however the same can be said about a lot > security related fixes. Sort of, although I wrote the original patch because it was dead easy to do and saved having to think too much about the problem, whereas the complexity of backporting largerly diminishes that imo. > What if it becomes exploitable in the future, would not it be nice to > have it in a 6 year LTS kernel? Even if people are stuck on an old LTS, they should still be taking the regular updates for it, and we would obviously need to backport the fix if it turned out to be exploitable (and hey, we could even test it then!). > > So I'm not going to Ack any of them. As with a lot of this side-channel > > stuff the cure is far worse than the disease. > Assuming that my v3 does build correctly, which it will, would you be > keen on changing your position? Note that I'm not trying to block this patch from going in, I'm just saying that I'm not supportive of it. Perhaps somebody from Arm can review it if they think it's worth the effort. Will