From: Jiri Olsa <jolsa@redhat.com>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, svens@linux.ibm.com, gor@linux.ibm.com,
sumanthk@linux.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH] perf stat: Fix s390x compile error on F32 utils/stat-display.c
Date: Tue, 25 Aug 2020 09:14:42 +0200 [thread overview]
Message-ID: <20200825071442.GB631468@krava> (raw)
In-Reply-To: <20200825063304.77733-1-tmricht@linux.ibm.com>
On Tue, Aug 25, 2020 at 08:33:04AM +0200, Thomas Richter wrote:
SNIP
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 57d0706e1330..cbe836649f84 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -117,12 +117,11 @@ static void aggr_printout(struct perf_stat_config *config,
> cpu_map__id_to_die(id),
> config->csv_output ? 0 : -3,
> cpu_map__id_to_cpu(id), config->csv_sep);
> - } else {
> + } else if (id > -1)
> fprintf(config->output, "CPU%*d%s",
> config->csv_output ? 0 : -7,
> evsel__cpus(evsel)->map[id],
> config->csv_sep);
> - }
I think we want multiple if lines within { } but
scripts/checkpatch.pl does not scream about this,
so leaving this to Arnaldo ;-)
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> break;
> case AGGR_THREAD:
> fprintf(config->output, "%*s-%*d%s",
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-08-25 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 6:33 Thomas Richter
2020-08-25 7:14 ` Jiri Olsa [this message]
2020-08-26 13:00 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825071442.GB631468@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sumanthk@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®