From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A50C433DF for ; Tue, 25 Aug 2020 12:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7160E20738 for ; Tue, 25 Aug 2020 12:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbgHYMft (ORCPT ); Tue, 25 Aug 2020 08:35:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:54598 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbgHYMfp (ORCPT ); Tue, 25 Aug 2020 08:35:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C521BAF8A; Tue, 25 Aug 2020 12:36:14 +0000 (UTC) Date: Tue, 25 Aug 2020 14:35:42 +0200 From: Petr Mladek To: Kieran Bingham , Andrew Morton Cc: Jan Kiszka , John Ogness , Baoquan He , Dave Young , Vivek Goyal , Jonathan Corbet , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2][next] update gdb scripts for lockless printk ringbuffer Message-ID: <20200825123542.GU4353@alley> References: <20200814212525.6118-1-john.ogness@linutronix.de> <20200821080813.GM4353@alley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2020-08-24 10:20:53, Kieran Bingham wrote: > Hi Petr, > > On 21/08/2020 09:55, Jan Kiszka wrote: > > On 21.08.20 10:08, Petr Mladek wrote: > >> On Fri 2020-08-14 23:31:23, John Ogness wrote: > >>> Hi, > >>> > >>> When we brought in the new lockless printk ringbuffer, we overlooked the gdb > >>> scripts. Here are a set of patches to implement gdb support for the new > >>> ringbuffer. > >>> > >>> John Ogness (2): > >>> scripts/gdb: add utils.read_ulong() > >>> scripts/gdb: update for lockless printk ringbuffer > >> > >> I am not fluent in the gdb macros and python so I did not try any > >> deep review. But both patches work for me: > >> > >> Tested-by: Petr Mladek > >> > >> I am going to give it few more days before pushing just in case there is > >> another feedback. > > Before 'pushing' ? > > What context do you mean here? These patches go through AKPM don't they? > Did I miss some update to procedures? Both patches should go into mainline together with the lockless printk ring buffer. It is already in linux-next via printk/linux.git, branch printk-rework. The plan is to get it into mainline when pr_cont() handling is solved. It is more complicated than we hoped for, see https://lore.kernel.org/r/20200824103538.31446-1-john.ogness@linutronix.de It is still not clear whether it will be ready for 5.10. Andrew, would you mind when I take the three gdb/lockless-printk related changes via printk tree to avoid synchronization problems? Best Regards, Petr