From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD715C433DF for ; Tue, 25 Aug 2020 19:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B372E2074D for ; Tue, 25 Aug 2020 19:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgHYTM3 (ORCPT ); Tue, 25 Aug 2020 15:12:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:44178 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgHYTM2 (ORCPT ); Tue, 25 Aug 2020 15:12:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 89B9DB70C; Tue, 25 Aug 2020 19:12:57 +0000 (UTC) Date: Tue, 25 Aug 2020 21:12:25 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: "Eric W. Biederman" , Christian Brauner , mingo@kernel.org, Peter Zijlstra , Thomas Gleixner , esyr@redhat.com, christian@kellner.me, areber@redhat.com, Shakeel Butt , cyphar@cyphar.com, Oleg Nesterov , adobriyan@gmail.com, Andrew Morton , gladkov.alexey@gmail.com, Michel Lespinasse , daniel.m.jordan@oracle.com, avagin@gmail.com, bernd.edlinger@hotmail.de, John Johansen , laoar.shao@gmail.com, Tim Murray , Minchan Kim , kernel-team , LKML , linux-fsdevel@vger.kernel.org, stable , linux-mm Subject: Re: [PATCH v2 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary Message-ID: <20200825191225.GK22869@dhcp22.suse.cz> References: <20200824153036.3201505-1-surenb@google.com> <87imd6n0qk.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 25-08-20 10:36:45, Suren Baghdasaryan wrote: > On Tue, Aug 25, 2020 at 9:38 AM Eric W. Biederman wrote: [...] > > > diff --git a/include/linux/oom.h b/include/linux/oom.h > > > index f022f581ac29..861f22bd4706 100644 > > > --- a/include/linux/oom.h > > > +++ b/include/linux/oom.h > > > @@ -55,6 +55,7 @@ struct oom_control { > > > }; > > > > > > extern struct mutex oom_lock; > > > +extern struct mutex oom_adj_lock; > > ^^^^^^^^^^^^^^ > > > > I understand moving this lock by why renaming it? > > To be consistent with the mutex name right above it. I'm ok keeping it > as before if this is too much additional churn. I guess Michal deals > with this code more than anyone else, so I'll wait for him to comment > on this one. I cannot say I would care deeply about naming. Consistency looks nice but if there is a preference to keep the lock then I will not object. -- Michal Hocko SUSE Labs