From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
m.szyprowski@samsung.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Wed, 26 Aug 2020 18:02:26 +0200 [thread overview]
Message-ID: <20200826160226.GU2403519@lunn.ch> (raw)
In-Reply-To: <dleftja6yhv4g2.fsf%l.stelmach@samsung.com>
> >> +module_param(comp, int, 0);
> >> +MODULE_PARM_DESC(comp, "0=Non-Compression Mode, 1=Compression Mode");
> >> +
> >> +module_param(ps_level, int, 0);
> >> +MODULE_PARM_DESC(ps_level,
> >> + "Power Saving Level (0:disable 1:level 1 2:level 2)");
> >> +
> >> +module_param(msg_enable, int, 0);
> >> +MODULE_PARM_DESC(msg_enable, "Message mask (see linux/netdevice.h for bitmap)");
> >> +
> >> +static char *macaddr;
> >> +module_param(macaddr, charp, 0);
> >> +MODULE_PARM_DESC(macaddr, "MAC address");
> >
> > I think MAC address as param is not accepted in mainline...
> >
>
> $ git grep MODULE_PARM_DESC\(macaddr -- drivers/net | wc -l
> 6
Yes, they exist. But still it is considered back practice, don't do
it, use device tree for MAC addresses.
Andrew
next prev parent reply other threads:[~2020-08-26 16:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200825170322eucas1p2c6619aa3e02d2762e07da99640a2451c@eucas1p2.samsung.com>
2020-08-25 17:03 ` Łukasz Stelmach
[not found] ` <CGME20200825170323eucas1p2d299a6ac365e6a70d802757d439bc77c@eucas1p2.samsung.com>
2020-08-25 17:03 ` [PATCH 2/3] ARM: dts: Add ethernet Łukasz Stelmach
2020-08-25 18:03 ` Andrew Lunn
2020-08-25 18:49 ` Krzysztof Kozlowski
[not found] ` <CGME20200825170323eucas1p15f2bbfa460f7ef787069dd3459dd77b3@eucas1p1.samsung.com>
2020-08-25 17:03 ` [PATCH 3/3] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-08-25 18:51 ` Krzysztof Kozlowski
[not found] ` <CGME20200826051134eucas1p23a1c91b2179678eecc5dd5eeb2d0e4c9@eucas1p2.samsung.com>
2020-08-26 5:11 ` Lukasz Stelmach
2020-08-26 6:46 ` Krzysztof Kozlowski
2020-08-25 17:19 ` [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Randy Dunlap
[not found] ` <CGME20200825173041eucas1p29cb450a15648e0ecb1e896fcbe0f9126@eucas1p2.samsung.com>
2020-08-25 17:30 ` Lukasz Stelmach
2020-08-25 17:55 ` Randy Dunlap
2020-08-25 18:01 ` Andrew Lunn
2020-08-26 7:13 ` Geert Uytterhoeven
[not found] ` <CGME20200907174710eucas1p1b06f854222c255719a63c72b043ecda2@eucas1p1.samsung.com>
2020-09-07 17:47 ` Lukasz Stelmach
[not found] ` <CGME20200907173945eucas1p240c0d7ebff3010a3bf752eaf8e619eb1@eucas1p2.samsung.com>
2020-09-07 17:39 ` Lukasz Stelmach
2020-09-07 18:18 ` Andrew Lunn
[not found] ` <CGME20200908174935eucas1p2f24d79b234152148b060c45863e3efeb@eucas1p2.samsung.com>
2020-09-08 17:49 ` Lukasz Stelmach
2020-09-08 18:22 ` Andrew Lunn
2020-09-14 22:29 ` jim.cromie
2020-08-25 18:44 ` Krzysztof Kozlowski
[not found] ` <CGME20200826145929eucas1p1367c260edb8fa003869de1da527039c0@eucas1p1.samsung.com>
2020-08-26 14:59 ` Lukasz Stelmach
2020-08-26 15:06 ` David Laight
2020-08-26 16:07 ` Andrew Lunn
[not found] ` <CGME20200907180715eucas1p1c1e41bb1ddb5a401a4d9c8cb6117e1f6@eucas1p1.samsung.com>
2020-09-07 18:06 ` Lukasz Stelmach
2020-08-26 16:02 ` Andrew Lunn [this message]
2020-08-26 16:45 ` Krzysztof Kozlowski
2020-08-26 16:52 ` Krzysztof Kozlowski
2020-08-25 20:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826160226.GU2403519@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome