From: Vinod Koul <vkoul@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ryan Lee <ryans.lee@maximintegrated.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
Naveen Manohar <naveen.m@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v2 1/5] ASoC: max98373: Fix return check for devm_regmap_init_sdw()
Date: Wed, 26 Aug 2020 22:03:36 +0530 [thread overview]
Message-ID: <20200826163340.3249608-2-vkoul@kernel.org> (raw)
In-Reply-To: <20200826163340.3249608-1-vkoul@kernel.org>
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on
failure which should be checked with IS_ERR. Also use PTR_ERR for
returning error codes.
Reported-by: Takashi Iwai <tiwai@suse.de>
Fixes: 56a5b7910e96 ("ASoC: codecs: max98373: add SoundWire support")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
sound/soc/codecs/max98373-sdw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c
index 5fe724728e84..e4675cfff7b2 100644
--- a/sound/soc/codecs/max98373-sdw.c
+++ b/sound/soc/codecs/max98373-sdw.c
@@ -838,8 +838,8 @@ static int max98373_sdw_probe(struct sdw_slave *slave,
/* Regmap Initialization */
regmap = devm_regmap_init_sdw(slave, &max98373_sdw_regmap);
- if (!regmap)
- return -EINVAL;
+ if (IS_ERR(regmap))
+ return PTR_ERR(regmap);
return max98373_init(slave, regmap);
}
--
2.26.2
next prev parent reply other threads:[~2020-08-26 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 16:33 [PATCH v2 0/5] ASoC: " Vinod Koul
2020-08-26 16:33 ` Vinod Koul [this message]
2020-08-26 16:33 ` [PATCH v2 2/5] ASoC: rt1308-sdw: " Vinod Koul
2020-08-26 16:33 ` [PATCH v2 3/5] ASoC: rt711: " Vinod Koul
2020-08-26 16:33 ` [PATCH v2 4/5] ASoC: rt715: " Vinod Koul
2020-08-26 16:33 ` [PATCH v2 5/5] ASoC: rt700: " Vinod Koul
2020-08-26 17:00 ` [PATCH v2 0/5] ASoC: " Pierre-Louis Bossart
2020-08-26 19:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826163340.3249608-2-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®