From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6DCC433E1 for ; Wed, 26 Aug 2020 16:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60BE12080C for ; Wed, 26 Aug 2020 16:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598459651; bh=qrdU18lvM1hFnhmTD3louuy0mIUGuLG/l5x75RkizpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=M5KsWx1QcFtfqKqwjcn5CWxh9iH+JBsAGkoW9j4NDofDFm80QjHMwAoBe+O5qEz8g 0XJO9+UnvPDN41WZoIiTuyGzBDWTq8f4taXpzfcigqxv95NqeyetqT/OdUo8JXK2PB BvWr8W+1AKskB3yDYxqQ9t1+sBUDWnBbLTNxYXBk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728047AbgHZQeH (ORCPT ); Wed, 26 Aug 2020 12:34:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:59472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727990AbgHZQd7 (ORCPT ); Wed, 26 Aug 2020 12:33:59 -0400 Received: from localhost.localdomain (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B522206FA; Wed, 26 Aug 2020 16:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598459639; bh=qrdU18lvM1hFnhmTD3louuy0mIUGuLG/l5x75RkizpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mO4JffxQQ09EMXsrmT0pqWPNRi9MRlrcgcYQ2NaaM+Z1rJztyj+syr0LgJL9XvQu8 bL+Z1HMMhrNb5GT5Ki+9LzOBDbMVuEb60ApfqSWqS1qWQqPmL8mnVdVXelCAuJX+gz U6Y4uKrh4AKg+PzdBdOibgED//7SHPL1D2bwr2Ms= From: Vinod Koul To: Mark Brown Cc: Vinod Koul , Takashi Iwai , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Oder Chiou , Shuming Fan , Takashi Iwai Subject: [PATCH v2 3/5] ASoC: rt711: Fix return check for devm_regmap_init_sdw() Date: Wed, 26 Aug 2020 22:03:38 +0530 Message-Id: <20200826163340.3249608-4-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200826163340.3249608-1-vkoul@kernel.org> References: <20200826163340.3249608-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 320b8b0d13b8 ("ASoC: rt711: add rt711 codec driver") Signed-off-by: Vinod Koul --- sound/soc/codecs/rt711-sdw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 45b928954b58..7efff130a638 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -452,8 +452,8 @@ static int rt711_sdw_probe(struct sdw_slave *slave, /* Regmap Initialization */ sdw_regmap = devm_regmap_init_sdw(slave, &rt711_sdw_regmap); - if (!sdw_regmap) - return -EINVAL; + if (IS_ERR(sdw_regmap)) + return PTR_ERR(sdw_regmap); regmap = devm_regmap_init(&slave->dev, NULL, &slave->dev, &rt711_regmap); -- 2.26.2