From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D10EC433E1 for ; Thu, 27 Aug 2020 12:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE3322177B for ; Thu, 27 Aug 2020 12:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728723AbgH0MhK (ORCPT ); Thu, 27 Aug 2020 08:37:10 -0400 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]:52403 "EHLO smtp2207-205.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728804AbgH0MLF (ORCPT ); Thu, 27 Aug 2020 08:11:05 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1618609|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_enroll_verification|0.0266949-0.00317964-0.970125;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03302;MF=frank@allwinnertech.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.IOlHiVn_1598530254; Received: from allwinnertech.com(mailfrom:frank@allwinnertech.com fp:SMTPD_---.IOlHiVn_1598530254) by smtp.aliyun-inc.com(10.147.42.253); Thu, 27 Aug 2020 20:10:59 +0800 From: Frank Lee To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de Cc: linux-kernel@vger.kernel.org, tiny.windzz@gamil.com, Yangtao Li Subject: [PATCH] sched: idle: Change the cpu_idle_poll() return type to void Date: Thu, 27 Aug 2020 20:10:34 +0800 Message-Id: <20200827121034.2744-1-frank@allwinnertech.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li No one cares about the return value of this function, which only increases the time spent in idle loop. Let's drop it. Signed-off-by: Yangtao Li --- kernel/sched/idle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index 6bf34986f45c..5250a7c466e6 100644 --- a/kernel/sched/idle.c +++ b/kernel/sched/idle.c @@ -52,7 +52,7 @@ static int __init cpu_idle_nopoll_setup(char *__unused) __setup("hlt", cpu_idle_nopoll_setup); #endif -static noinline int __cpuidle cpu_idle_poll(void) +static noinline void __cpuidle cpu_idle_poll(void) { rcu_idle_enter(); trace_cpu_idle_rcuidle(0, smp_processor_id()); @@ -65,8 +65,6 @@ static noinline int __cpuidle cpu_idle_poll(void) start_critical_timings(); trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id()); rcu_idle_exit(); - - return 1; } /* Weak implementations for optional arch specific functions */ -- 2.28.0