From: peterz@infradead.org
To: Xianting Tian <tian.xianting@h3c.com>
Cc: <viro@zeniv.linux.org.uk>, <bcrl@kvack.org>, <mingo@redhat.com>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
<dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
<bsegall@google.com>, <mgorman@suse.de>, <jack@suse.cz>,
<linux-fsdevel@vger.kernel.org>, <linux-aio@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aio: make aio wait path to account iowait time
Date: Fri, 28 Aug 2020 11:07:29 +0200 [thread overview]
Message-ID: <20200828090729.GT1362448@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200828060712.34983-1-tian.xianting@h3c.com>
On Fri, Aug 28, 2020 at 02:07:12PM +0800, Xianting Tian wrote:
> As the normal aio wait path(read_events() ->
> wait_event_interruptible_hrtimeout()) doesn't account iowait time, so use
> this patch to make it to account iowait time, which can truely reflect
> the system io situation when using a tool like 'top'.
Do be aware though that io_schedule() is potentially far more expensive
than regular schedule() and io-wait accounting as a whole is a
trainwreck.
When in_iowait is set schedule() and ttwu() will have to do additional
atomic ops, and (much) worse, PSI will take additional locks.
And all that for a number that, IMO, is mostly useless, see the comment
with nr_iowait().
But, if you don't care about performance, and want to see a shiny random
number generator, by all means, use io_schedule().
next prev parent reply other threads:[~2020-08-28 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 6:07 Xianting Tian
2020-08-28 8:56 ` Jan Kara
2020-08-28 9:07 ` peterz [this message]
2020-08-28 9:41 ` Jan Kara
2020-08-28 10:51 ` peterz
2020-08-28 11:57 ` Tianxianting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828090729.GT1362448@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bcrl@kvack.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tian.xianting@h3c.com \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome