mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: rjw@rjwysocki.net, viresh.kumar@linaro.org,
	dietmar.eggemann@arm.com, catalin.marinas@arm.com,
	sudeep.holla@arm.com, will@kernel.org,
	valentin.schneider@arm.com
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, ionela.voinescu@arm.com
Subject: [PATCH v4 1/5] arch_topology: validate input frequencies to arch_set_freq_scale()
Date: Fri, 28 Aug 2020 18:32:59 +0100	[thread overview]
Message-ID: <20200828173303.11939-2-ionela.voinescu@arm.com> (raw)
In-Reply-To: <20200828173303.11939-1-ionela.voinescu@arm.com>

The current frequency passed to arch_set_freq_scale() could end up
being 0, signaling an error in setting a new frequency. Also, if the
maximum frequency in 0, this will result in a division by 0 error.

Therefore, validate these input values before using them for the
setting of the frequency scale factor.

Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
---
 drivers/base/arch_topology.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 75f72d684294..5708eb724790 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -33,6 +33,11 @@ void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq,
 	unsigned long scale;
 	int i;
 
+	if (unlikely(!cur_freq || !max_freq)) {
+		WARN_ON_ONCE(1);
+		return;
+	}
+
 	/*
 	 * If the use of counters for FIE is enabled, just return as we don't
 	 * want to update the scale factor with information from CPUFREQ.
-- 
2.17.1


  reply	other threads:[~2020-08-28 17:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 17:32 [PATCH v4 0/5] cpufreq: improve frequency invariance support Ionela Voinescu
2020-08-28 17:32 ` Ionela Voinescu [this message]
2020-08-31 11:13   ` [PATCH v4 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Viresh Kumar
2020-09-01 20:57     ` Ionela Voinescu
2020-08-28 17:33 ` [PATCH v4 2/5] cpufreq: move invariance setter calls in cpufreq core Ionela Voinescu
2020-08-28 17:33 ` [PATCH v4 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Ionela Voinescu
2020-08-31 11:14   ` Viresh Kumar
2020-08-28 17:33 ` [PATCH v4 4/5] arch_topology, cpufreq: constify arch_* cpumasks Ionela Voinescu
2020-08-28 17:33 ` [PATCH v4 5/5] arch_topology, arm, arm64: define arch_scale_freq_invariant() Ionela Voinescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828173303.11939-2-ionela.voinescu@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=valentin.schneider@arm.com \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®