From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
od@zcrc.me
Subject: Re: [PATCH v2 1/2] drm/ingenic: Fix leak of device_node pointer
Date: Sat, 29 Aug 2020 23:07:27 +0200 [thread overview]
Message-ID: <20200829210727.GE796939@ravnborg.org> (raw)
In-Reply-To: <20200827114404.36748-1-paul@crapouillou.net>
On Thu, Aug 27, 2020 at 01:44:03PM +0200, Paul Cercueil wrote:
> of_graph_get_remote_node() requires of_node_put() to be called on the
> device_node pointer when it's no more in use.
>
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index ada990a7f911..c1bcb93aed2d 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -978,6 +978,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
> }
>
> drm_of_component_match_add(dev, &match, compare_of, np);
> + of_node_put(np);
>
> return component_master_add_with_match(dev, &ingenic_master_ops, match);
> }
> --
> 2.28.0
next prev parent reply other threads:[~2020-08-29 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:44 Paul Cercueil
2020-08-27 11:44 ` [PATCH v2 2/2] drm/ingenic: Fix driver not probing when IPU port is missing Paul Cercueil
2020-08-29 21:08 ` Sam Ravnborg
2020-08-31 0:21 ` Ezequiel Garcia
2020-08-31 0:47 ` Paul Cercueil
2020-08-29 21:07 ` Sam Ravnborg [this message]
2020-08-30 22:55 ` [PATCH v2 1/2] drm/ingenic: Fix leak of device_node pointer Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829210727.GE796939@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome