From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A309AC433E6 for ; Sun, 30 Aug 2020 08:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DE81208CA for ; Sun, 30 Aug 2020 08:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598775065; bh=UHrlQ3jb0To1Qcfdx1uid0gHlvTRA2SrFLLJNnU3YHg=; h=From:To:Cc:Subject:Date:List-ID:From; b=sh1wPNNtHBQw9IxdsdEpY6BI+MWWKqNMUB9k2wiJ47XF7IVEedfLSLrE1WMSjsoOm 7BUYIiUdpwEfOs0iblpYsmg99k5/Mu7UYuOki9zAjC1XC7LEn56jUnsGErifLKitoJ Z23R1Nboh63TBXWVggzhY4GewVA+NnaZsZdnzTQo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725934AbgH3IK4 (ORCPT ); Sun, 30 Aug 2020 04:10:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:55512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727855AbgH3IJn (ORCPT ); Sun, 30 Aug 2020 04:09:43 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58F2620714; Sun, 30 Aug 2020 08:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598774982; bh=UHrlQ3jb0To1Qcfdx1uid0gHlvTRA2SrFLLJNnU3YHg=; h=From:To:Cc:Subject:Date:From; b=OlkPhXmtxIm25KwszEbSZVLc0+Hx2wObPtXFQBxan067WH5HuM6BTXsKszrD7Jsev Kdd1bzxImfgZf90dYSbseFET9yxx9TApEEdoOzGeVxIz3N3rVCaJyKTlHI+lrQz2ik ZmeYnojRo3xAVYJq/e5Fb4dVJMDQi13nVlLPBiJE= From: Krzysztof Kozlowski To: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] rtc: s3c: Simplify with dev_err_probe() Date: Sun, 30 Aug 2020 10:09:37 +0200 Message-Id: <20200830080937.14367-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s3c.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index e1b50e682fc4..24a41909f049 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -494,13 +494,8 @@ static int s3c_rtc_probe(struct platform_device *pdev) if (info->data->needs_src_clk) { info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); if (IS_ERR(info->rtc_src_clk)) { - ret = PTR_ERR(info->rtc_src_clk); - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, - "failed to find rtc source clock\n"); - else - dev_dbg(&pdev->dev, - "probe deferred due to missing rtc src clk\n"); + ret = dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_src_clk), + "failed to find rtc source clock\n"); goto err_src_clk; } ret = clk_prepare_enable(info->rtc_src_clk); -- 2.17.1