From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC13C433E6 for ; Sun, 30 Aug 2020 08:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A09021548 for ; Sun, 30 Aug 2020 08:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgH3ILX (ORCPT ); Sun, 30 Aug 2020 04:11:23 -0400 Received: from gofer.mess.org ([88.97.38.141]:49287 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727859AbgH3IKe (ORCPT ); Sun, 30 Aug 2020 04:10:34 -0400 Received: by gofer.mess.org (Postfix, from userid 1000) id E4624C63F6; Sun, 30 Aug 2020 09:10:04 +0100 (BST) Date: Sun, 30 Aug 2020 09:10:04 +0100 From: Sean Young To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mauro Carvalho Chehab , Sergey Kozlov , Abylay Ospan , Hans Verkuil , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: Re: [PATCH v1] [media] netup_unidvb: use generic power management Message-ID: <20200830081004.GA17376@gofer.mess.org> References: <20200728092717.937023-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728092717.937023-1-vaibhavgupta40@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 02:57:17PM +0530, Vaibhav Gupta wrote: > The .suspend() and .resume() callbacks are not defined for this driver. > Still, their power management structure follows the legacy framework. To > bring it under the generic framework, simply remove the binding of > callbacks from "struct pci_driver". Unlisted fields in a static struct initializer will get set to 0 (or NULL for pointers) already. Removing the NULL initializers will not change anything. Possibly you want to remove the redundant initializers but your commit message should say so. Sean > > Signed-off-by: Vaibhav Gupta > --- > drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > index 80a7c41baa90..6f3125c2d097 100644 > --- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > @@ -1016,8 +1016,6 @@ static struct pci_driver netup_unidvb_pci_driver = { > .id_table = netup_unidvb_pci_tbl, > .probe = netup_unidvb_initdev, > .remove = netup_unidvb_finidev, > - .suspend = NULL, > - .resume = NULL, > }; > > module_pci_driver(netup_unidvb_pci_driver); > -- > 2.27.0