From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 429CFC433E6 for ; Mon, 31 Aug 2020 19:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0965D20BED for ; Mon, 31 Aug 2020 19:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598901359; bh=GDy1fsI36v2ZyxfLvzTCNTXvzujrkKd4Gu/L2okdFrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=A2RYNQYs0hIvxeRxauBn+WpeTugaHdnWaNYhTAgOtGi5Q00UsJ7/18aUm+Sgeajq7 8AbhSRRaQCo5TBuo/tnopTwOTWWBjzfeOQ0l9Sd+rvSDmQner9DfUXSSAcGGj7e+Go OsEC+htuShUQgPgJOBe2WnaPTOWsmAypZXlHfTNE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728446AbgHaTP4 (ORCPT ); Mon, 31 Aug 2020 15:15:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:40682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgHaTP4 (ORCPT ); Mon, 31 Aug 2020 15:15:56 -0400 Received: from X1 (unknown [65.49.58.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69CBE2068F; Mon, 31 Aug 2020 19:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598901356; bh=GDy1fsI36v2ZyxfLvzTCNTXvzujrkKd4Gu/L2okdFrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=atYzD5gpMnIG6BFdeJ/em0LdLf1SHIZektt7yokFaON6dBOuazpy6TdDZ1BDD4kRJ 7ibDldGN9Kh+T9Fz1RkWQHzdztYTxNdYBenNZkEWvazPxsPj0n9jfVuGJHpOk3HtB7 QYaGjrSXSPNiPT7D2uOWcEtCkPml7P6EQnn8sEac= Date: Mon, 31 Aug 2020 12:15:53 -0700 From: Andrew Morton To: Christian Borntraeger Cc: Gerald Schaefer , Linus Torvalds , linux-mm , LKML , Vasily Gorbik , Alexander Gordeev , linux-s390@vger.kernel.org, Heiko Carstens , Claudio Imbrenda Subject: Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding Message-Id: <20200831121553.8be5dcdbdbc5256846ac513e@linux-foundation.org> In-Reply-To: <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> References: <20200828140314.8556-1-gerald.schaefer@linux.ibm.com> <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2020 13:53:36 +0200 Christian Borntraeger wrote: > > > On 28.08.20 16:03, Gerald Schaefer wrote: > have some feedback soon if option 1 or option 2 would be acceptable > from a common code perspective. Andrew, who of the mm people would > be the right one to decide? Jason and John Hubbard are doing most of the work in there at present, Both patches look OK to me from a non-s390 perspective. Unless we plan to implement Jason's more-general approach this time, I'd be inclined to defer to the s390 people as to the preferred implementation.