From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
Gustavo Padovan <gustavo@padovan.org>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
Date: Tue, 1 Sep 2020 15:32:00 +0200 [thread overview]
Message-ID: <20200901133200.GE2352366@phenom.ffwll.local> (raw)
In-Reply-To: <81dc0a34-90f6-401a-f846-924fdff4aaff@amd.com>
On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
> > Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
> > warning in drivers/dma-buf/dma-fence.c:
> >
> > ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Gustavo Padovan <gustavo@padovan.org>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: linux-media@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
>
> Acked-by: Christian König <christian.koenig@amd.com>
Will you merge these two to drm-misc-fixes or should someone else?
Always a bit confusing when maintainers reply with acks/r-b but not what
they'll do with the patch :-)
Cheers, Daniel
>
> > ---
> > drivers/dma-buf/dma-fence.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
> > +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
> > @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
> > /**
> > * dma_fence_end_signalling - end a critical DMA fence signalling section
> > + * @cookie: opaque cookie from dma_fence_begin_signalling()
> > *
> > * Closes a critical section annotation opened by dma_fence_begin_signalling().
> > */
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-09-01 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 4:17 Randy Dunlap
2020-08-31 10:02 ` Christian König
2020-09-01 13:32 ` Daniel Vetter [this message]
2020-09-01 13:37 ` Christian König
2020-09-01 15:06 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901133200.GE2352366@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®