From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Julien Thierry <jthierry@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mbenes@suse.cz, benh@kernel.crashing.org
Subject: Re: [PATCH v4 0/4] Remove dependency of check subcmd upon orc
Date: Tue, 1 Sep 2020 11:05:38 -0500 [thread overview]
Message-ID: <20200901160538.a2t3qiagdanx6xtw@treble> (raw)
In-Reply-To: <20200825124742.29782-1-jthierry@redhat.com>
On Tue, Aug 25, 2020 at 01:47:38PM +0100, Julien Thierry wrote:
> Hi,
>
> Matt Helsley's change[1] provided a base framework to opt-in/out
> objtool subcommands at compile time. This makes it easier for
> architectures to port objtool, one subcommand at a time.
>
> Orc generation relies on the check operation implementation. However,
> the way this is done causes the check implementation to depend on the
> implementation of orc generation functions to call if orc generation is
> requested. This means that in order to implement check subcmd, orc
> subcmd also need to be implemented.
>
> These patches aim at removing that dependency, having orc subcmd
> being built on top of the check subcmd.
>
>
> Changes since v3 [2]:
> - Rebased on v5.9-rc1
> - Renamed objtool_setup_file() to objtool_open_read()
> - Fixed misplaced elf_write() when file->elf->changed is true
> - Avoid additional allocation for orc data and compile out orc
> definition when not needed instead
>
> [1] https://www.spinics.net/lists/kernel/msg3510844.html
> [2] https://lkml.org/lkml/2020/7/30/415
Thanks, I grabbed the patches and will work with Peter to get them
merged.
--
Josh
next prev parent reply other threads:[~2020-09-01 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 12:47 Julien Thierry
2020-08-25 12:47 ` [PATCH v4 1/4] objtool: Move object file loading out of check Julien Thierry
2020-08-25 12:47 ` [PATCH v4 2/4] objtool: Move orc outside " Julien Thierry
2020-08-28 9:11 ` Miroslav Benes
2020-08-25 12:47 ` [PATCH v4 3/4] objtool: orc: Skip setting orc_entry for non-text sections Julien Thierry
2020-08-25 12:47 ` [PATCH v4 4/4] objtool: check: Use orc definition only when needed Julien Thierry
2020-08-28 9:24 ` Miroslav Benes
2020-09-01 16:05 ` Josh Poimboeuf [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-25 12:46 [PATCH v4 0/4] Remove dependency of check subcmd upon orc Julien Thierry
2020-08-25 12:49 ` Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901160538.a2t3qiagdanx6xtw@treble \
--to=jpoimboe@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®