From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891EDC433E6 for ; Tue, 1 Sep 2020 16:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 530162078B for ; Tue, 1 Sep 2020 16:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598976888; bh=wSYh3X+qxwyoZekqoM20nCWZcWw1dfhsCUJVuXIEPaE=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=MxaMYiyf2eF2MWu6W91vMBlpENnV83u90yASoZBGSKam6c8OJ0uQ8XeNHHsaJAMdO 8lCJMNyMJfucTwKpS3Ei4TdB91lJhc6MRFA8IXkvnIivp1wQd8HbB4uubb84HzUqUm T8+S9Y6q4Jmr1DdexTA9btVvTTMsNmDyBQKQpP6g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731885AbgIAQNt (ORCPT ); Tue, 1 Sep 2020 12:13:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731108AbgIAQNo (ORCPT ); Tue, 1 Sep 2020 12:13:44 -0400 Received: from paulmck-ThinkPad-P72.home (unknown [50.45.173.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76C99204EC; Tue, 1 Sep 2020 16:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598976820; bh=wSYh3X+qxwyoZekqoM20nCWZcWw1dfhsCUJVuXIEPaE=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=WKc3b7+l3qEJxpTCJykOhIL5mC4+Tc+4xUuoNh86NmlHnYI62zNec4SSfKIrB0rAl ejM533Ibu1SyDPQ5Dx6TmnAip7Lh6b8EbpmM29rchZrIEuzNWLMiSMXe5Dank5qQjr uH/ubRDB/JaW46oPe7Zn39dD8nr2lIcTL1jF36E8= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 1FB1F35226A5; Tue, 1 Sep 2020 09:13:40 -0700 (PDT) Date: Tue, 1 Sep 2020 09:13:40 -0700 From: "Paul E. McKenney" To: peterz@infradead.org Cc: Lina Iyer , Ulf Hansson , Naresh Kamboju , "Rafael J. Wysocki" , Saravana Kannan , open list , linux-mmc , lkft-triage@lists.linaro.org, rcu@vger.kernel.org, Linux PM , Anders Roxell , Arnd Bergmann , Rajendra Nayak , John Stultz , Stephen Boyd , Lars Povlsen , madhuparnabhowmik10@gmail.com, Viresh Kumar , Vincent Guittot , Thomas Gleixner Subject: Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper Message-ID: <20200901161340.GC29330@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200831194402.GD2855@paulmck-ThinkPad-P72> <20200901104206.GU1362448@hirez.programming.kicks-ass.net> <20200901154417.GD20303@codeaurora.org> <20200901155014.GF2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901155014.GF2674@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2020 at 05:50:14PM +0200, peterz@infradead.org wrote: > On Tue, Sep 01, 2020 at 09:44:17AM -0600, Lina Iyer wrote: > > > > > > > I could add RCU_NONIDLE for the calls to pm_runtime_put_sync_suspend() > > > > > > > and pm_runtime_get_sync() in psci_enter_domain_idle_state(). Perhaps > > > > > > > that's the easiest approach, at least to start with. > > > I think this would be nice. This should also cover the case, where PM domain > > power off notification callbacks call trace function internally. Right? > > That's just more crap for me to clean up later :-( > > trace_*_rcuidle() and RCU_NONIDLE() need to die, not proliferate. Moving the idle-entry boundary further in is good in any number of ways. But experience indicates that no matter how far you move it, there will be something complex further in. Unless you are pushing it all the way into all the arch-specific code down as far as it can possibly go? Thanx, Paul