From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05890C433E2 for ; Wed, 2 Sep 2020 22:43:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB13520758 for ; Wed, 2 Sep 2020 22:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgIBWnD (ORCPT ); Wed, 2 Sep 2020 18:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgIBWnD (ORCPT ); Wed, 2 Sep 2020 18:43:03 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25AAC061244; Wed, 2 Sep 2020 15:43:02 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C42E4157347A0; Wed, 2 Sep 2020 15:26:15 -0700 (PDT) Date: Wed, 02 Sep 2020 15:43:01 -0700 (PDT) Message-Id: <20200902.154301.2111662696967293761.davem@davemloft.net> To: xie.he.0141@gmail.com Cc: khc@pm.waw.pl, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: Re: [PATCH net] drivers/net/wan/hdlc: Change the default of hard_header_len to 0 From: David Miller In-Reply-To: <20200902120706.3411-1-xie.he.0141@gmail.com> References: <20200902120706.3411-1-xie.he.0141@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 02 Sep 2020 15:26:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie He Date: Wed, 2 Sep 2020 05:07:06 -0700 > Change the default value of hard_header_len in hdlc.c from 16 to 0. > > Currently there are 6 HDLC protocol drivers, among them: > > hdlc_raw_eth, hdlc_cisco, hdlc_ppp, hdlc_x25 set hard_header_len when > attaching the protocol, overriding the default. So this patch does not > affect them. > > hdlc_raw and hdlc_fr don't set hard_header_len when attaching the > protocol. So this patch will change the hard_header_len of the HDLC > device for them from 16 to 0. > > This is the correct change because both hdlc_raw and hdlc_fr don't have > header_ops, and the code in net/packet/af_packet.c expects the value of > hard_header_len to be consistent with header_ops. > > In net/packet/af_packet.c, in the packet_snd function, > for AF_PACKET/DGRAM sockets it would reserve a headroom of > hard_header_len and call dev_hard_header to fill in that headroom, > and for AF_PACKET/RAW sockets, it does not reserve the headroom and > does not call dev_hard_header, but checks if the user has provided a > header of length hard_header_len (in function dev_validate_header). > > Cc: Krzysztof Halasa > Cc: Martin Schiller > Signed-off-by: Xie He Applied, thanks.