From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC1AC433E6 for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6474F2087D for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FwZ8Z44S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgIBCyV (ORCPT ); Tue, 1 Sep 2020 22:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgIBCyB (ORCPT ); Tue, 1 Sep 2020 22:54:01 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F003C061244 for ; Tue, 1 Sep 2020 19:53:55 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id o68so2024042pfg.2 for ; Tue, 01 Sep 2020 19:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=FwZ8Z44SN7D4KRJA4npu9mvkVI0wXuCLYH1l2mLJj8aelE0Rk0L2zjDZgtqEkgrGP5 Vdlh91A3FK9cW00PtADerkvJE2DbDmOjQwdEO6PDh5uBo9JY+jiyUUcP5hnU8Rb7ZGKm uWPcKxWzPxVjBdhDrkoEXl9Yq9bB3c9PCSDYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=hlgdvUWlXwfUzEXPs/fU13aOXifr/0eylcOl/BC0Lk5xqdOXI4pR3zZ8RF7QwasqqZ 16O323jbaAo5wkBuaqYP7enAMwnTJG1EOJZpudkG+61gxVdXVf1u04aH0IvaBvm0267I eRyBatKxavwnujPAGwao47z5/IFXkUqPK1FtthVYQUEQw+xOIrkiO9FY1lNg0uZALbiP Xz+5hO6iQCC/U2vNA7vcOVvqEtfxnqO/9v7AQHB/qB8tj6DL57uw+nLdJhyGrXkRfe3n GQ6U2Ya8eZh2dsoN/XNSEeFFy4cz0IVKNohZBO907fsZNwBCL10JilLszxYZWeohcI9G 8Hfw== X-Gm-Message-State: AOAM533BWHqC0MTFxujuILOM+ceBHKGD2SsB8sXbsQ1Pb/ct6jNS7GHo IR18DUb2LyHEtP9DiZBShXhv4w== X-Google-Smtp-Source: ABdhPJwGPpNyETRl4VuDPYZiIlH2eDa0br1azIegj/wzZtKCn4U41u9SncizzsUSeepmeQxRgh8NDQ== X-Received: by 2002:aa7:824a:: with SMTP id e10mr1243727pfn.62.1599015234783; Tue, 01 Sep 2020 19:53:54 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 31sm2560666pgo.17.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Cc: Kees Cook , Borislav Petkov , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 4/5] x86/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:46 -0700 Message-Id: <20200902025347.2504702-5-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 4346ffb2e39f..154259f18b8b 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -209,6 +209,10 @@ ifdef CONFIG_X86_64 LDFLAGS_vmlinux += -z max-page-size=0x200000 endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + archscripts: scripts_basic $(Q)$(MAKE) $(build)=arch/x86/tools relocs -- 2.25.1