From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162F1C433E2 for ; Wed, 2 Sep 2020 15:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5A4920773 for ; Wed, 2 Sep 2020 15:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599059250; bh=Kf4AGkwBeCGoHHALVeorzcgycX+eJy9K4IemTaY2rug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MUqaq1dT1u3zH7njsgtKX+tZ8sCTV/RyEVVzsi6OKtSTCywJxaWZNQ70/iwQSC7qz VjSAroNFOkJQl7CP/7TaOhsLamovbBRKFo18DDeTtpueOOwUaBR8yRZMGmEvMaf0w0 cCR8sMZGfQIIeER7kMp/yoMaK3e1uJEFS8x1KFrI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728223AbgIBPHW (ORCPT ); Wed, 2 Sep 2020 11:07:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:42886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728161AbgIBPFl (ORCPT ); Wed, 2 Sep 2020 11:05:41 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33E06208DB; Wed, 2 Sep 2020 15:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599059141; bh=Kf4AGkwBeCGoHHALVeorzcgycX+eJy9K4IemTaY2rug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VSgk85zVnJwt/VLg6KrgcafVnr5qa9RP9MooVdCpAlnwQtnqKIbPFJrhmtrv38w4y jXfAlVoqW4GNgLiLrc23muvJZTjKhoGoiR3RyIEUbnXfgbCEpTFdbU+BmwPVNcNLxr EDn8X09KLElHzjuCD5vsFq83sVfcZ3idPyRGI1GU= From: Krzysztof Kozlowski To: Corentin Labbe , Herbert Xu , "David S. Miller" , Maxime Ripard , Chen-Yu Tsai , =?UTF-8?q?Horia=20Geant=C4=83?= , Aymen Sghaier , Maxime Coquelin , Alexandre Torgue , Chen Zhou , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Cc: Krzysztof Kozlowski Subject: [PATCH 2/4] crypto: caam - Simplify with dev_err_probe() Date: Wed, 2 Sep 2020 17:05:28 +0200 Message-Id: <20200902150530.14640-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200902150530.14640-1-krzk@kernel.org> References: <20200902150530.14640-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/crypto/caam/caamalg_qi2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c index 0441e4ff2df2..076c6b04bea9 100644 --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c @@ -5115,8 +5115,7 @@ static int dpaa2_caam_probe(struct fsl_mc_device *dpseci_dev) /* DPIO */ err = dpaa2_dpseci_dpio_setup(priv); if (err) { - if (err != -EPROBE_DEFER) - dev_err(dev, "dpaa2_dpseci_dpio_setup() failed\n"); + dev_err_probe(dev, err, "dpaa2_dpseci_dpio_setup() failed\n"); goto err_dpio_setup; } -- 2.17.1