From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F98C433E2 for ; Thu, 3 Sep 2020 08:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C71F620897 for ; Thu, 3 Sep 2020 08:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgICI12 (ORCPT ); Thu, 3 Sep 2020 04:27:28 -0400 Received: from elvis.franken.de ([193.175.24.41]:50522 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbgICI1M (ORCPT ); Thu, 3 Sep 2020 04:27:12 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kDkaL-0000I1-07; Thu, 03 Sep 2020 10:27:09 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 4DDD5C0E86; Thu, 3 Sep 2020 10:24:40 +0200 (CEST) Date: Thu, 3 Sep 2020 10:24:40 +0200 From: Thomas Bogendoerfer To: Davidlohr Bueso Cc: oleg@redhat.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] MIPS: Use rcu to lookup a task in mipsmt_sys_sched_setaffinity() Message-ID: <20200903082440.GH6220@alpha.franken.de> References: <20200831201402.2837-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831201402.2837-1-dave@stgolabs.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2020 at 01:14:02PM -0700, Davidlohr Bueso wrote: > The call simply looks up the corresponding task (without iterating > the tasklist), which is safe under rcu instead of the tasklist_lock. > In addition, the setaffinity counter part already does this. > > Signed-off-by: Davidlohr Bueso > --- > arch/mips/kernel/mips-mt-fpaff.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]