From: Paul Cercueil <paul@crapouillou.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <Peter.Chen@nxp.com>,
Cristian Birsan <cristian.birsan@microchip.com>,
Felipe Balbi <balbi@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
Tony Prisk <linux@prisktech.co.nz>, Bin Liu <b-liu@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org,
Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 06/20] usb/chipidea: core: Use pm_ptr() macro
Date: Thu, 3 Sep 2020 13:25:40 +0200 [thread overview]
Message-ID: <20200903112554.34263-7-paul@crapouillou.net> (raw)
In-Reply-To: <20200903112554.34263-1-paul@crapouillou.net>
Use the newly introduced pm_ptr() macro, and mark the suspend/resume
functions __maybe_unused. These functions can then be moved outside the
CONFIG_PM_SUSPEND block, and the compiler can then process them and
detect build failures independently of the config. If unused, they will
simply be discarded by the compiler.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/usb/chipidea/core.c | 26 +++++++++++---------------
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index aa40e510b806..af64ab98fb56 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -1231,9 +1231,8 @@ static int ci_hdrc_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
/* Prepare wakeup by SRP before suspend */
-static void ci_otg_fsm_suspend_for_srp(struct ci_hdrc *ci)
+static void __maybe_unused ci_otg_fsm_suspend_for_srp(struct ci_hdrc *ci)
{
if ((ci->fsm.otg->state == OTG_STATE_A_IDLE) &&
!hw_read_otgsc(ci, OTGSC_ID)) {
@@ -1245,7 +1244,7 @@ static void ci_otg_fsm_suspend_for_srp(struct ci_hdrc *ci)
}
/* Handle SRP when wakeup by data pulse */
-static void ci_otg_fsm_wakeup_by_srp(struct ci_hdrc *ci)
+static void __maybe_unused ci_otg_fsm_wakeup_by_srp(struct ci_hdrc *ci)
{
if ((ci->fsm.otg->state == OTG_STATE_A_IDLE) &&
(ci->fsm.a_bus_drop == 1) && (ci->fsm.a_bus_req == 0)) {
@@ -1259,7 +1258,7 @@ static void ci_otg_fsm_wakeup_by_srp(struct ci_hdrc *ci)
}
}
-static void ci_controller_suspend(struct ci_hdrc *ci)
+static void __maybe_unused ci_controller_suspend(struct ci_hdrc *ci)
{
disable_irq(ci->irq);
ci_hdrc_enter_lpm(ci, true);
@@ -1277,7 +1276,7 @@ static void ci_controller_suspend(struct ci_hdrc *ci)
* interrupt (wakeup int) only let the controller be out of
* low power mode, but not handle any interrupts.
*/
-static void ci_extcon_wakeup_int(struct ci_hdrc *ci)
+static void __maybe_unused ci_extcon_wakeup_int(struct ci_hdrc *ci)
{
struct ci_hdrc_cable *cable_id, *cable_vbus;
u32 otgsc = hw_read_otgsc(ci, ~0);
@@ -1294,7 +1293,7 @@ static void ci_extcon_wakeup_int(struct ci_hdrc *ci)
ci_irq(ci->irq, ci);
}
-static int ci_controller_resume(struct device *dev)
+static int __maybe_unused ci_controller_resume(struct device *dev)
{
struct ci_hdrc *ci = dev_get_drvdata(dev);
int ret;
@@ -1332,8 +1331,7 @@ static int ci_controller_resume(struct device *dev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int ci_suspend(struct device *dev)
+static int __maybe_unused ci_suspend(struct device *dev)
{
struct ci_hdrc *ci = dev_get_drvdata(dev);
@@ -1366,7 +1364,7 @@ static int ci_suspend(struct device *dev)
return 0;
}
-static int ci_resume(struct device *dev)
+static int __maybe_unused ci_resume(struct device *dev)
{
struct ci_hdrc *ci = dev_get_drvdata(dev);
int ret;
@@ -1386,9 +1384,8 @@ static int ci_resume(struct device *dev)
return ret;
}
-#endif /* CONFIG_PM_SLEEP */
-static int ci_runtime_suspend(struct device *dev)
+static int __maybe_unused ci_runtime_suspend(struct device *dev)
{
struct ci_hdrc *ci = dev_get_drvdata(dev);
@@ -1408,13 +1405,12 @@ static int ci_runtime_suspend(struct device *dev)
return 0;
}
-static int ci_runtime_resume(struct device *dev)
+static int __maybe_unused ci_runtime_resume(struct device *dev)
{
return ci_controller_resume(dev);
}
-#endif /* CONFIG_PM */
-static const struct dev_pm_ops ci_pm_ops = {
+static const struct dev_pm_ops __maybe_unused ci_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(ci_suspend, ci_resume)
SET_RUNTIME_PM_OPS(ci_runtime_suspend, ci_runtime_resume, NULL)
};
@@ -1424,7 +1420,7 @@ static struct platform_driver ci_hdrc_driver = {
.remove = ci_hdrc_remove,
.driver = {
.name = "ci_hdrc",
- .pm = &ci_pm_ops,
+ .pm = pm_ptr(&ci_pm_ops),
.dev_groups = ci_groups,
},
};
--
2.28.0
next prev parent reply other threads:[~2020-09-03 11:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:25 [PATCH 00/20] usb: Use new " Paul Cercueil
2020-09-03 11:25 ` [PATCH 01/20] usb/host: ohci-platform: Use " Paul Cercueil
2020-09-03 15:34 ` Alan Stern
2020-09-03 11:25 ` [PATCH 02/20] usb/host: ehci-spear: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 03/20] usb/host: ehci-npcm7xx: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 04/20] usb/host: ehci-platform: " Paul Cercueil
2020-09-03 15:47 ` Alan Stern
2020-09-03 11:25 ` [PATCH 05/20] usb/cdns3: core: " Paul Cercueil
2020-09-03 11:25 ` Paul Cercueil [this message]
2020-09-05 0:02 ` [PATCH 06/20] usb/chipidea: " Peter Chen
2020-09-03 11:25 ` [PATCH 07/20] usb/misc: usb3503: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 08/20] usb/misc: usb4604: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 09/20] usb/musb: am35x: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 10/20] usb/musb: da8xx: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 11/20] usb/musb: musb_dsps: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 12/20] usb/musb: ux500: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 13/20] usb/phy: am335x: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 14/20] usb/phy: mxs-usb: " Paul Cercueil
2020-09-05 0:08 ` Peter Chen
2020-09-07 6:07 ` Felipe Balbi
2020-09-03 11:25 ` [PATCH 15/20] usb/gadget/udc: atmel: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 16/20] usb/gadget/udc: bdc: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 17/20] usb/gadget/udc: mv-u3d: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 18/20] usb/gadget/udc: pch: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 19/20] usb/gadget/udc: renesas: " Paul Cercueil
2020-09-03 11:25 ` [PATCH 20/20] usb/gadget/udc: snps: " Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903112554.34263-7-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Peter.Chen@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=avifishman70@gmail.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=benjaminfair@google.com \
--cc=cristian.birsan@microchip.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=openbmc@lists.ozlabs.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®