From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40ABC43461 for ; Thu, 3 Sep 2020 22:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1EF020678 for ; Thu, 3 Sep 2020 22:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728775AbgICWDF (ORCPT ); Thu, 3 Sep 2020 18:03:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41650 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726891AbgICWDE (ORCPT ); Thu, 3 Sep 2020 18:03:04 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kDxJs-00D71Z-Rg; Fri, 04 Sep 2020 00:03:00 +0200 Date: Fri, 4 Sep 2020 00:03:00 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, Vivien Didelot , "David S. Miller" , Jakub Kicinski , open list Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used Message-ID: <20200903220300.GH3112546@lunn.ch> References: <20200902210328.3131578-1-f.fainelli@gmail.com> <20200903011324.GE3071395@lunn.ch> <28177f17-1557-bd69-e96b-c11c39d71145@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28177f17-1557-bd69-e96b-c11c39d71145@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The firmware provides the Device Tree but here is the relevant section for > you pasted below. The problematic device is a particular revision of the > silicon (D0) which got later fixed (E0) however the Device Tree was created > after the fixed platform, not the problematic one. Both revisions of the > silicon are in production. > > There should have been an internal MDIO bus created for that chip revision > such that we could have correctly parented phy@0 (bcm53125 below) as child > node of the internal MDIO bus, but you have to realize that this was done > back in 2014 when DSA was barely revived as an active subsystem. The > BCM53125 node should have have been converted to an actual switch node at > some point, I use a mdio_boardinfo overlay downstream to support the switch > as a proper b53/DSA switch, anyway. I was expecting something like that. I think this patch needs a comment in the code explaining it is a workaround for a DT blob which cannot be changed. Maybe also make it conditional on the board compatible string? Thanks Andrew