From: Mark Brown <broonie@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
linuxarm@huawei.com, mauro.chehab@huawei.com,
John Stultz <john.stultz@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>, Yu Chen <chenyu56@huawei.com>,
Rob Herring <robh+dt@kernel.org>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Wei Xu <xuwei5@hisilicon.com>
Subject: Re: [RFC 00/10] Add USB support for Hikey 970
Date: Fri, 4 Sep 2020 13:34:53 +0100 [thread overview]
Message-ID: <20200904123453.GD4625@sirena.org.uk> (raw)
In-Reply-To: <20200904142849.7d3fed88@coco.lan>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Fri, Sep 04, 2020 at 02:28:49PM +0200, Mauro Carvalho Chehab wrote:
> It sounds that the only power supply related to USB is for the USB
> hub (ldo17), with sounds unlikely to affect dwc3. Yet, just in case,
> I added a dirty hack at dwc3_probe:
> <snip>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 25c686a752b0..e42be91fe6c2 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1491,6 +1491,11 @@ static int dwc3_probe(struct platform_device *pdev)
>
> }
> +struct regulator *reg;
> +reg = devm_regulator_get(dev, "ldo17");
> +ret = PTR_ERR_OR_ZERO(reg);
> +if (ret) return ret;
A regulator_get() is going to do absolutely nothing to the state of the
regulator, if you're trying to enable it you need to do regulator_enable()
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-04 12:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 10:23 Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 01/10] phy: hisilicon: add USB physical layer for Kirin 3670 Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 02/10] phy: hisilicon: phy-hi3670-usb3: fix some issues at the init code Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 03/10] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace Mauro Carvalho Chehab
2020-09-09 20:15 ` Rob Herring
2020-09-10 5:37 ` Mauro Carvalho Chehab
2020-09-15 16:51 ` Rob Herring
2020-09-04 10:23 ` [RFC 04/10] phy: hisilicon: phy-hi3670-usb3: fix coding style Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 05/10] phy: hisilicon: phy-hi3670-usb3: change some DT properties Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 06/10] dt-bindings: phy: convert phy-kirin970-usb3.txt to yaml Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 07/10] MAINTAINERS: add myself as maintainer for Kirin 970 USB PHY Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 08/10] misc: hisi_hikey_usb: Driver to support onboard USB gpio hub on Hikey960 Mauro Carvalho Chehab
2020-09-04 12:53 ` Randy Dunlap
2020-09-04 10:23 ` [RFC 09/10] misc: hisi_hikey_usb: add support for Hikey 970 Mauro Carvalho Chehab
2020-09-04 12:23 ` Mark Brown
2020-09-04 12:38 ` Mauro Carvalho Chehab
2020-09-04 12:45 ` Mark Brown
2020-09-04 13:47 ` Mauro Carvalho Chehab
2020-09-04 10:23 ` [RFC 10/10] dts: hisilicon: add support for USB3 on " Mauro Carvalho Chehab
2020-09-04 10:53 ` [RFC 00/10] Add USB support for " Robin Murphy
2020-09-04 12:28 ` Mauro Carvalho Chehab
2020-09-04 12:34 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904123453.GD4625@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=chenyu56@huawei.com \
--cc=davem@davemloft.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mani@kernel.org \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®