mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Yang <yang.yang@vivo.com>
To: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: onlyfever@icloud.com, yang.yang@vivo.com
Subject: [PATCH] kyber: Fix crash in kyber_finish_request()
Date: Mon,  7 Sep 2020 00:43:46 -0700	[thread overview]
Message-ID: <20200907074346.5383-1-yang.yang@vivo.com> (raw)

Kernel crash when requeue flush request.
It can be reproduced as below:

[    2.517297] Unable to handle kernel paging request at virtual address ffffffd8071c0b00
...
[    2.517468] pc : clear_bit+0x18/0x2c
[    2.517502] lr : sbitmap_queue_clear+0x40/0x228
[    2.517503] sp : ffffff800832bc60 pstate : 00c00145
...
[    2.517599] Process ksoftirqd/5 (pid: 51, stack limit = 0xffffff8008328000)
[    2.517602] Call trace:
[    2.517606]  clear_bit+0x18/0x2c
[    2.517619]  kyber_finish_request+0x74/0x80
[    2.517627]  blk_mq_requeue_request+0x3c/0xc0
[    2.517637]  __scsi_queue_insert+0x11c/0x148
[    2.517640]  scsi_softirq_done+0x114/0x130
[    2.517643]  blk_done_softirq+0x7c/0xb0
[    2.517651]  __do_softirq+0x208/0x3bc
[    2.517657]  run_ksoftirqd+0x34/0x60
[    2.517663]  smpboot_thread_fn+0x1c4/0x2c0
[    2.517667]  kthread+0x110/0x120
[    2.517669]  ret_from_fork+0x10/0x18

Signed-off-by: Yang Yang <yang.yang@vivo.com>
---
 block/kyber-iosched.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
index a38c5ab103d1..af73afe7a05c 100644
--- a/block/kyber-iosched.c
+++ b/block/kyber-iosched.c
@@ -611,6 +611,9 @@ static void kyber_finish_request(struct request *rq)
 {
 	struct kyber_queue_data *kqd = rq->q->elevator->elevator_data;
 
+	if (unlikely(!(rq->rq_flags & RQF_ELVPRIV)))
+		return;
+
 	rq_clear_domain_token(kqd, rq);
 }
 
-- 
2.17.1


             reply	other threads:[~2020-09-07  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07  7:43 Yang Yang [this message]
2020-09-07 16:41 ` Jens Axboe
2020-09-08 19:00   ` Omar Sandoval
2020-09-08 19:49     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907074346.5383-1-yang.yang@vivo.com \
    --to=yang.yang@vivo.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onlyfever@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®