From: Mark Brown <broonie@kernel.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: derek.fang@realtek.com, Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5682: Have global name clock option for parent clk
Date: Mon, 7 Sep 2020 12:06:01 +0100 [thread overview]
Message-ID: <20200907110601.GC4907@sirena.org.uk> (raw)
In-Reply-To: <20200907040038.3124-1-akshu.agrawal@amd.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Mon, Sep 07, 2020 at 09:30:37AM +0530, Akshu Agrawal wrote:
> When adding parent clk(mclk) to wclk, this adds fallback option
> for the case where global clk name is used.
> @@ -2780,6 +2780,7 @@ static int rt5682_register_dai_clks(struct snd_soc_component *component)
> if (rt5682->mclk) {
> init.parent_data = &(struct clk_parent_data){
> .fw_name = "mclk",
> + .name = __clk_get_name(rt5682->mclk),
> };
> init.num_parents = 1;
> }
I don't understand this change - we clearly already have the clock so
why can't we just use whatever we used when we originally looked it up
here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-07 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 4:00 Akshu Agrawal
2020-09-07 11:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907110601.GC4907@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=derek.fang@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®