From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D68C43461 for ; Mon, 7 Sep 2020 11:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA24D215A4 for ; Mon, 7 Sep 2020 11:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbgIGLrs (ORCPT ); Mon, 7 Sep 2020 07:47:48 -0400 Received: from mga06.intel.com ([134.134.136.31]:37818 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729126AbgIGLrH (ORCPT ); Mon, 7 Sep 2020 07:47:07 -0400 IronPort-SDR: thXuwRKQuFBhGB6UmAIc5/dx/+EcAGntHFTkWaH4NNui3C3BOQuONmj5QGzMSghY4c4tD1GYLG tuMVGPMgKN8w== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="219548628" X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="219548628" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2020 04:47:05 -0700 IronPort-SDR: hZmu1Fenn9gReIus5x9P12yka4olRDezreXmS/q9RHVoAmqu3UqbckOcRdqpiX+tEKdVxcRqbj jSBe8rlIGSvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="333141567" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 07 Sep 2020 04:47:03 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kFFbw-00EwH2-Ad; Mon, 07 Sep 2020 14:47:00 +0300 Date: Mon, 7 Sep 2020 14:47:00 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jonathan Corbet , Mika Westerberg , Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-doc , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 10/23] gpio: mockup: fix resource leak in error path Message-ID: <20200907114700.GW1891694@smile.fi.intel.com> References: <20200904154547.3836-1-brgl@bgdev.pl> <20200904154547.3836-11-brgl@bgdev.pl> <20200904170028.GG1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2020 at 01:04:59PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 7:00 PM Andy Shevchenko > wrote: > > On Fri, Sep 04, 2020 at 05:45:34PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > If the module init function fails after creating the debugs directory, > > > it's never removed. Add proper cleanup calls to avoid this resource > > > leak. > > > > Does it fix existing bug? > > You mean - should it go into stable? The bug is quite unlikely but > yeah, probably. Yes. That sounds to me like Fixes: is needed. -- With Best Regards, Andy Shevchenko