mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: jason.wessel@windriver.com, dianders@chromium.org,
	oleg@redhat.com, kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH -next] kdb: Use newer api for tasklist scanning
Date: Mon, 7 Sep 2020 13:03:22 -0700	[thread overview]
Message-ID: <20200907200322.shuexcour6kmegq6@linux-p48b> (raw)
In-Reply-To: <20200907134614.guc4tzj3knnihbe4@holly.lan>

On Mon, 07 Sep 2020, Daniel Thompson wrote:

>No objections to the change but kdb doesn't use tsk->thread_group,
>it uses do_each_thread/while_each_thread. Can we change this to
>say that is osbsolete and racy to use while_each_thread() (that's
>pretty much what the description of the patch that introduced
>for_each_thread said)?

Well while_each_thread() is just a loop around next_thread(),
which uses tsk->thread_group. But sure, I can rephrase a v2 to say
while_each_thread.

>
>Additionally the debug_core uses do_each_thread/while_each_thread.
>Presumably that would like to be changed as well?

Are you referring to gdb_cmd_query()? Yeah, that's another one that
can be replaced. Because we need not worry about races, it's rather
simple to justify both replacements in the same patch, which I'll
add to v2.

Thanks,
Davidlohr

  reply	other threads:[~2020-09-07 20:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 19:34 Davidlohr Bueso
2020-09-03 13:39 ` Oleg Nesterov
2020-09-07 13:46 ` Daniel Thompson
2020-09-07 20:03   ` Davidlohr Bueso [this message]
2020-09-07 20:32   ` [PATCH v2] " Davidlohr Bueso
2020-09-09 13:37     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907200322.shuexcour6kmegq6@linux-p48b \
    --to=dave@stgolabs.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dbueso@suse.de \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®