mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Arun Easi <aeasi@marvell.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nilesh Javali <njavali@marvell.com>,
	Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v2 4/4] qla2xxx: Handle incorrect entry_type entries
Date: Tue, 8 Sep 2020 09:57:53 +0200	[thread overview]
Message-ID: <20200908075753.ov64u2rmhet3jmlu@beryllium.lan> (raw)
In-Reply-To: <alpine.LRH.2.21.9999.2009072346360.28578@irv1user01.caveonetworks.com>

Hi Arun,

On Mon, Sep 07, 2020 at 11:47:48PM -0700, Arun Easi wrote:
> Could you drop the above comment about firmware, as it is speculation at
> this point?

Sure, no problem.

> It'd be best to take a chip reset path, rather than assuming the
> packet is good and having the appropriate handler called (hacky).
> An approach similar to the one done at the beginning of
> qla2x00_get_sp_from_handle() is what I had in mind.

Ok, agreed a reset is probably the safest choice.

> I'd have preferred a common approach across the different IOCB types
> as an attempt to harden the code, but that will be a little more
> involved work. This looks ok.

Yes, I was pondering on it but I don't know enough to really come up
with something reasonable. Currently our customers report only this
hickup. So this is really only a partial workaround.

Thanks,
Daniel

  reply	other threads:[~2020-09-08  7:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 16:18 [PATCH v2 0/4] qla2xxx: A couple crash fixes Daniel Wagner
2020-08-31 16:18 ` [PATCH v2 1/4] qla2xxx: Warn if done() or free() are called on an already freed srb Daniel Wagner
2020-09-08  6:42   ` Arun Easi
2020-08-31 16:18 ` [PATCH v2 2/4] qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle() Daniel Wagner
2020-09-08  6:43   ` Arun Easi
2020-08-31 16:18 ` [PATCH v2 3/4] qla2xxx: Drop unused function argument from qla2x00_get_sp_from_handle() Daniel Wagner
2020-09-08  6:46   ` Arun Easi
2020-09-08  7:52     ` Daniel Wagner
2020-08-31 16:18 ` [PATCH v2 4/4] qla2xxx: Handle incorrect entry_type entries Daniel Wagner
2020-09-08  6:47   ` Arun Easi
2020-09-08  7:57     ` Daniel Wagner [this message]
2020-08-31 19:11 ` [PATCH v2 0/4] qla2xxx: A couple crash fixes Martin Wilck
2020-09-08  6:41 ` Arun Easi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908075753.ov64u2rmhet3jmlu@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=aeasi@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mwilck@suse.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®