From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B3AC43461 for ; Tue, 8 Sep 2020 19:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5EE72137B for ; Tue, 8 Sep 2020 19:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731575AbgIHTcm (ORCPT ); Tue, 8 Sep 2020 15:32:42 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:44768 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731012AbgIHTcR (ORCPT ); Tue, 8 Sep 2020 15:32:17 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 00C0F1C0B7F; Tue, 8 Sep 2020 21:32:14 +0200 (CEST) Date: Tue, 8 Sep 2020 21:32:14 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Al Grant , Andi Kleen , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: Re: [PATCH 4.19 40/88] perf tools: Correct SNOOPX field offset Message-ID: <20200908193214.GA6758@duo.ucw.cz> References: <20200908152221.082184905@linuxfoundation.org> <20200908152223.128046647@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <20200908152223.128046647@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Al Grant >=20 > [ Upstream commit 39c0a53b114d0317e5c4e76b631f41d133af5cb0 ] >=20 > perf_event.h has macros that define the field offsets in the data_src > bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. >=20 > These are distinct fields, and the bitfield layout in perf_mem_data_src > confirms that SNOOPX should be at offset 38. >=20 > Committer notes: >=20 > This was extracted from a larger patch that also contained kernel > changes. >=20 > Fixes: 52839e653b5629bd ("perf tools: Add support for printing new > mem_info encodings") > +++ b/tools/include/uapi/linux/perf_event.h > @@ -1079,7 +1079,7 @@ union perf_mem_data_src { > =20 > #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ > /* 1 free */ > -#define PERF_MEM_SNOOPX_SHIFT 37 > +#define PERF_MEM_SNOOPX_SHIFT 38 > =20 We still have: =2E/include/uapi/linux/perf_event.h:#define PERF_MEM_SNOOPX_SHIFT 37 (note tools/include vs. include). Should those be in sync before merging this to stable? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX1fcPgAKCRAw5/Bqldv6 8janAJ0SZLRix7HkKpoh8hwE2zOl5qd5qwCffo1hrLj9rLNHSbavYFi1ysLKXOk= =wnJl -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--