mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	Arnaud Lacombe <lacombar@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v1] x86/defconfigs: Unbreak 32-bit defconfig builds
Date: Wed, 9 Sep 2020 13:14:00 +0300	[thread overview]
Message-ID: <20200909101400.GK1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200909080020.GA2437694@gmail.com>

On Wed, Sep 09, 2020 at 10:00:20AM +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 08, 2020 at 02:13:54PM +0200, Ingo Molnar wrote:
> > > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

...

> > uname => x86_64
> > make i386_defconfig
> > 
> > It was very convenient to not supply ARCH when build on multi-arch host.
> 
> Nice, TIL about the extended 'make *config' targets. :-)
> 
> Curiously, they aren't even mentioned in the 'configuration targets' 
> section of 'make help' and are not discoverable unless you know their 
> locations.
> 
> Anyway, your fix makes sense now to me too.

I see you applied original patch from Daniel.

> Do we need a similar for x86_64 defconfig, when built on 32-bit hosts? (not 
> that anyone does that in practice, but just for completeness.)

I never heard about such use, I consider it more academic rather than
practical.

> Also, it would be nice if there was a way to annotate the defconfig for 
> 'make savedefconfig' preserved these ARCH choices - it currently strips out 
> all non-enabled options that match their default configuration value.

Hmm... Yes, perhaps it would be nice to have such an exception.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-09-09 10:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 10:00 Andy Shevchenko
2020-09-08 12:13 ` Ingo Molnar
2020-09-08 13:43   ` Andy Shevchenko
2020-09-09  8:00     ` Ingo Molnar
2020-09-09 10:14       ` Andy Shevchenko [this message]
2020-09-08 13:49   ` Jarkko Nikula
2020-09-08 17:50   ` Randy Dunlap
2020-09-08 18:45     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909101400.GK1891694@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome