From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7127C10DAA for ; Wed, 9 Sep 2020 17:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80E4621556 for ; Wed, 9 Sep 2020 17:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729860AbgIIRaM (ORCPT ); Wed, 9 Sep 2020 13:30:12 -0400 Received: from ms.lwn.net ([45.79.88.28]:58476 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgIIRaK (ORCPT ); Wed, 9 Sep 2020 13:30:10 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id C62A17C0; Wed, 9 Sep 2020 17:30:09 +0000 (UTC) Date: Wed, 9 Sep 2020 11:30:08 -0600 From: Jonathan Corbet To: Coly Li Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Jarkko Sakkinen , Stefan Berger , Dan Williams , James Bottomley , Jason Gunthorpe , Mimi Zohar , Peter Huewe Subject: Re: [PATCH v4] docs: trusted-encrypted.rst: update parameters for command examples Message-ID: <20200909113008.6ee6e109@lwn.net> In-Reply-To: <20200821135356.15737-1-colyli@suse.de> References: <20200821135356.15737-1-colyli@suse.de> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Aug 2020 21:53:56 +0800 Coly Li wrote: > The parameters in command examples for tpm2_createprimary and > tpm2_evictcontrol are outdated, people (like me) are not able to create > trusted key by these command examples. > > This patch updates the parameters of command example tpm2_createprimary > and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8 > and tpm2-tools-4.1, people can create a trusted key by following the > examples in this document. > > Signed-off-by: Coly Li > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Stefan Berger > Cc: Dan Williams > Cc: James Bottomley > Cc: Jason Gunthorpe > Cc: Jonathan Corbet > Cc: Mimi Zohar > Cc: Peter Huewe > --- > Changelog: > v4: update Reviewed-by list, and Cc linux-doc and linux-integrity > maintainers. > v3: update commit log with review comments from Jarkko Sakkinen. > v2: remove the change of trusted key related operation. > v1: initial version. > > Documentation/security/keys/trusted-encrypted.rst | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst > index 9483a7425ad5..1da879a68640 100644 > --- a/Documentation/security/keys/trusted-encrypted.rst > +++ b/Documentation/security/keys/trusted-encrypted.rst > @@ -39,10 +39,9 @@ With the IBM TSS 2 stack:: > > Or with the Intel TSS 2 stack:: > > - #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt > + #> tpm2_createprimary --hierarchy o -G rsa2048 -c key.ctxt > [...] > - handle: 0x800000FF > - #> tpm2_evictcontrol -c key.ctxt -p 0x81000001 > + #> tpm2_evictcontrol -c key.ctxt 0x81000001 > persistentHandle: 0x81000001 This has been languishing, sorry; I've just applied it. Thanks, jon