From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"tiwai@suse.com" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] Device addition to the tlv320adcx140 and tas2562
Date: Wed, 9 Sep 2020 16:35:25 +0100 [thread overview]
Message-ID: <20200909153525.GF4926@sirena.org.uk> (raw)
In-Reply-To: <8c47c81f-5f83-2cf4-7bf1-62201b35bed3@ti.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wed, Sep 09, 2020 at 10:01:51AM -0500, Dan Murphy wrote:
> For the TLV320adcx140 driver I have another device which is register and
> bitmap compatible but it does not support Analog microphones or Line In like
> the x140.
> Should I add a new driver specifically for this part or should I add the new
> audio maps, widgets and controls to the existing driver? This would make
> this existing driver really big in terms of LoC and object size.
Are they sharing anything (eg, the code is the same but the data tables
vary) or is it just two unrelated devices?
> Similar question for the TAS2562. I have a new device that is register and
> bitmap compatible but removes the I/V sense. Adding this new device to the
> existing driver wouldn't be as intrusive as the x140 as the audio map and
> controls are much simpler
That definitely sounds like sharing the driver makes sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-09 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 15:01 Dan Murphy
2020-09-09 15:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909153525.GF4926@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®