mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean O'Brien <seobrien@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Sean O'Brien <seobrien@chromium.org>
Subject: Re: [PATCH v3] HID: add vivaldi HID driver
Date: Wed,  9 Sep 2020 15:31:48 -0700	[thread overview]
Message-ID: <20200909223148.419843-1-seobrien@chromium.org> (raw)
In-Reply-To: <ad58952a64bdf8e64bf4da5461db43c6a30d3b70.camel@perches.com>

> if ((parser->global.usage_page << 16) != HID_UP_GOOGLEVENDOR)
>	return;

I'm a bit worried about adding an early return, as it may cause issues
if someone doesn't notice when adding another case. Looking at this again
I can easily remove the second line break now that I've changed the group
name.

  reply	other threads:[~2020-09-09 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 22:03 Sean O'Brien
2020-09-09 22:11 ` Joe Perches
2020-09-09 22:31   ` Sean O'Brien [this message]
2020-09-21 22:49 ` ping: " Sean O'Brien
2020-09-30 20:45 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909223148.419843-1-seobrien@chromium.org \
    --to=seobrien@chromium.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®