mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mayflowerera@gmail.com
Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links
Date: Thu, 10 Sep 2020 15:05:48 -0700 (PDT)	[thread overview]
Message-ID: <20200910.150548.696841576525551255.davem@davemloft.net> (raw)
In-Reply-To: <20200910095609.17999-1-mayflowerera@gmail.com>

From: Era Mayflower <mayflowerera@gmail.com>
Date: Thu, 10 Sep 2020 09:56:09 +0000

> -		pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN;
> -		if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) {
> -			pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != %d\n",
> -				  nla_len(tb_sa[MACSEC_SA_ATTR_PN]), pn_len);
> +			pr_notice("macsec: nl: upd_rxsa: pn length on non-xpn links must be %d\n",
> +				  MACSEC_DEFAULT_PN_LEN);
> +			rtnl_unlock();
> +			return -EINVAL;
> +
> +		default:
> +			pr_notice("macsec: nl: upd_rxsa: pn length must be %d or %d\n",
> +				  MACSEC_DEFAULT_PN_LEN, MACSEC_XPN_PN_LEN);
>  			rtnl_unlock();

Please do not spam the kernel log like this.  Instead, report this
info via netlink extended ACKs.

Thank you.

      reply	other threads:[~2020-09-10 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  9:56 Era Mayflower
2020-09-10 22:05 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910.150548.696841576525551255.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mayflowerera@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®