From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, p.zabel@pengutronix.de,
linux-hwmon@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
songjun.Wu@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, rtanwar@maxlinear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller
Date: Thu, 10 Sep 2020 12:33:53 +0300 [thread overview]
Message-ID: <20200910093353.GN1891694@smile.fi.intel.com> (raw)
In-Reply-To: <41cf7b4d-2476-4d0e-0dae-f0200649d7dd@linux.intel.com>
On Thu, Sep 10, 2020 at 03:26:04PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 6:33 pm, Andy Shevchenko wrote:
> > On Wed, Sep 09, 2020 at 02:52:05PM +0800, Rahul Tanwar wrote:
...
> >> +#include <linux/of.h>
> > I don't see anything special about OF here.
> > Perhaps
> > mod_devicetable.h
> > property.h
> > ?
>
> of.h is needed because of of_property_read_u8_array(). I will add
> mod_devicetable.h.
> property.h seems not required at all.
if you use device property API then it will be more generic.
...
> >> +static struct regmap_config pvt_regmap_config = {
> >> + .reg_bits = 32,
> >> + .reg_stride = 4,
> >> + .val_bits = 32,
> > How do you use regmap's lock?
>
> We mutex lock whenever read temperature or voltage values from the registers.
> All non-probe/non-init paths. We do not override regmap's internal lock.
Exactly and my point is why do we have too many locks?
> >> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-10 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 6:52 [PATCH 0/2] Add driver for Moortec " Rahul Tanwar
2020-09-09 6:52 ` [PATCH 1/2] Add DT bindings schema for " Rahul Tanwar
2020-09-09 20:48 ` Rob Herring
2020-09-09 6:52 ` [PATCH 2/2] Add driver for Moortec MR75203 " Rahul Tanwar
2020-09-09 10:33 ` Andy Shevchenko
2020-09-10 7:26 ` Tanwar, Rahul
2020-09-10 9:33 ` Andy Shevchenko [this message]
2020-09-09 15:05 ` Guenter Roeck
[not found] ` <c72665ba-b594-bbb0-00c5-ed763233d609@linux.intel.com>
2020-09-10 9:34 ` Guenter Roeck
2020-09-10 9:46 ` Andy Shevchenko
2020-09-10 9:53 ` Tanwar, Rahul
2020-09-10 10:35 ` Philipp Zabel
2020-09-10 10:42 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910093353.GN1891694@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=songjun.Wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®