From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only
Date: Thu, 10 Sep 2020 11:42:06 -0700 [thread overview]
Message-ID: <20200910184206.GA17305@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20200910182901.GK8357@zn.tnic>
On Thu, Sep 10, 2020 at 08:29:19PM +0200, Borislav Petkov wrote:
> Ok, with all those changes, I don't think the following nice and juicy
> message can be overlooked:
>
> [ 32.267830] mce: MSR access error: RDMSR from 0x1234 at rIP: 0xffffffff8102ed62 (mce_rdmsrl+0x12/0x50)
With only one call site the rIP isn't super helpful at the moment. But
once you start selling those "MSR or die" T-shirts everyone will want
to use this :-)
> [ 32.267838] Call Trace:
> [ 32.267838] <#MC>
> [ 32.267838] do_machine_check+0xbd/0x9f0
> [ 32.267839] ? trigger_mce+0x7/0x10
> [ 32.267839] exc_machine_check+0x77/0xd0
> [ 32.267840] asm_exc_machine_check+0x19/0x30
Do we need the stack trace twice? Once from your fixup
function, second from panic()?
-Tony
next prev parent reply other threads:[~2020-09-10 18:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 21:21 Borislav Petkov
2020-09-07 20:06 ` Luck, Tony
2020-09-08 9:46 ` Borislav Petkov
2020-09-08 10:08 ` Borislav Petkov
2020-09-08 15:07 ` Luck, Tony
2020-09-08 15:25 ` Borislav Petkov
2020-09-09 11:30 ` Borislav Petkov
2020-09-09 18:20 ` Luck, Tony
2020-09-09 20:03 ` Borislav Petkov
2020-09-10 18:29 ` Borislav Petkov
2020-09-10 18:38 ` [PATCH -v2] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR Borislav Petkov
2020-09-10 18:42 ` Luck, Tony [this message]
2020-09-10 18:54 ` [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Borislav Petkov
2020-09-10 19:43 ` Luck, Tony
2020-09-07 20:16 ` Andy Lutomirski
2020-09-07 20:27 ` Borislav Petkov
2020-09-11 9:47 ` [tip: ras/core] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910184206.GA17305@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®