mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>
To: <robh+dt@kernel.org>, <joel@jms.id.au>, <andrew@aj.id.au>,
	<minyard@acm.org>, <linus.walleij@linaro.org>,
	<haiyue.wang@linux.intel.com>, <cyrilbur@gmail.com>,
	<rlippert@google.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<openbmc@lists.ozlabs.org>
Cc: <ryan_chen@aspeedtech.com>
Subject: [PATCH 3/4] ipmi: kcs: aspeed: Fix LPC register offsets
Date: Fri, 11 Sep 2020 11:46:30 +0800	[thread overview]
Message-ID: <20200911034631.8473-4-chiawei_wang@aspeedtech.com> (raw)
In-Reply-To: <20200911034631.8473-1-chiawei_wang@aspeedtech.com>

The LPC register offsets are fixed to adapt to the LPC DTS change,
where the LPC partitioning is removed.

Signed-off-by: Chia-Wei, Wang <chiawei_wang@aspeedtech.com>
---
 drivers/char/ipmi/kcs_bmc_aspeed.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
index a140203c079b..8843cf867a5d 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -27,7 +27,6 @@
 
 #define KCS_CHANNEL_MAX     4
 
-/* mapped to lpc-bmc@0 IO space */
 #define LPC_HICR0            0x000
 #define     LPC_HICR0_LPC3E          BIT(7)
 #define     LPC_HICR0_LPC2E          BIT(6)
@@ -52,15 +51,13 @@
 #define LPC_STR1             0x03C
 #define LPC_STR2             0x040
 #define LPC_STR3             0x044
-
-/* mapped to lpc-host@80 IO space */
-#define LPC_HICRB            0x080
+#define LPC_HICRB            0x100
 #define     LPC_HICRB_IBFIF4         BIT(1)
 #define     LPC_HICRB_LPC4E          BIT(0)
-#define LPC_LADR4            0x090
-#define LPC_IDR4             0x094
-#define LPC_ODR4             0x098
-#define LPC_STR4             0x09C
+#define LPC_LADR4            0x110
+#define LPC_IDR4             0x114
+#define LPC_ODR4             0x118
+#define LPC_STR4             0x11C
 
 struct aspeed_kcs_bmc {
 	struct regmap *map;
-- 
2.17.1


  parent reply	other threads:[~2020-09-11  4:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  3:46 [PATCH 0/4] Remove LPC register partitioning Chia-Wei, Wang
2020-09-11  3:46 ` [PATCH 1/4] ARM: dts: Remove LPC BMC and Host partitions Chia-Wei, Wang
2020-09-11  3:46 ` [PATCH 2/4] soc: aspeed: Fix LPC register offsets Chia-Wei, Wang
2020-09-11  3:46 ` Chia-Wei, Wang [this message]
2020-09-11  3:46 ` [PATCH 4/4] pinctrl: aspeed-g5: " Chia-Wei, Wang
2020-09-29 12:42   ` Linus Walleij
2020-10-01  0:42     ` Andrew Jeffery
2020-09-11  4:03 ` [PATCH 0/4] Remove LPC register partitioning Joel Stanley
2020-09-11  4:45   ` Andrew Jeffery
2020-09-11  8:21     ` ChiaWei Wang
2020-09-28  7:43       ` Ryan Chen
2020-09-30  6:11         ` Andrew Jeffery
2020-09-30  7:54           ` ChiaWei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911034631.8473-4-chiawei_wang@aspeedtech.com \
    --to=chiawei_wang@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=cyrilbur@gmail.com \
    --cc=haiyue.wang@linux.intel.com \
    --cc=joel@jms.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rlippert@google.com \
    --cc=robh+dt@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®