From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC540C433E2 for ; Fri, 11 Sep 2020 04:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67EC8221E8 for ; Fri, 11 Sep 2020 04:45:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mWUO7v67" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725780AbgIKEpN (ORCPT ); Fri, 11 Sep 2020 00:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgIKEpJ (ORCPT ); Fri, 11 Sep 2020 00:45:09 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BEDBC061573; Thu, 10 Sep 2020 21:45:09 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id fa1so1114179pjb.0; Thu, 10 Sep 2020 21:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GkavzkycfND+4vCO4VeMuzt7qDfojSlqnl/vJMxoJ74=; b=mWUO7v67Y6xXVzWk3lUJ0Xc+U+hXxP+LiKgr8S1C8lYRYvLawsv+HwfKW+PdYa7Xr8 4FZCpEW60nNVlSfjBdEAnRwSL6d7BLOG5IxOdEcPVGja0R2vdlGQDexqU4+cnW0tXnAC 4piV8hlet/mzc1ubJJGbUratt+qr6+m8/FL233KLhzFRt9dnjw/m0LFz3MDPp0FYJ2UI e6RPJXhD9IToMJ9YGEmFzaZB9RudhES4UCrXDMQFTXekCHnJgjZvpibJLBVE42BGA0dT yQp+x4Z0dbE4fh5SG1UxqkI94n5Wn/p8Bh1s1bCptn1pAAZSr2GS5f+wjLQmBW9qVze7 6MRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GkavzkycfND+4vCO4VeMuzt7qDfojSlqnl/vJMxoJ74=; b=ZtY7jCc6Px1HBNfJIeWgA8mMRbH8xQFzSVZy9eaqTt043IZwZ3uWrxRRjS40FCYax6 NA1lZpsOnvDTYdsvOm3nleZsShYl415VgllvCojJYY+gEws+ONjIPwir1gfNmeK/GiwN 9on9qH6vM4KuC7iPA9/0XyiHEjQSLEY8HMscYDBy46hqyV0eUpo3GkpE3CjacXC0U7G2 Ic8K79/BDbyknSNE7K+WUWACZT5pS60//yoM7D5hG1vPel70xvQ2bVcfylFjcS58jghK tVoM2kZEDOD+dsThPfpMNexLQtMK2dvJ7fQGniDPZZQfqD0w32LO0zTcqfAqBiY1gZUj 5shA== X-Gm-Message-State: AOAM531OesXk9BIkGaNoHEzZjGSOcN4pefDZqqWMBQFozbHrFOByTpNy 3Guvz4rlr9hB1Y0+hmTZPdRujA10aTI= X-Google-Smtp-Source: ABdhPJwrP7C4ZNKEuVVFvnL2lUjp5HzDw0xYe6dftWod5cniZ2dUxjHLK5uCNxid9TR/kz30soFbhQ== X-Received: by 2002:a17:90a:104f:: with SMTP id y15mr523800pjd.45.1599799508685; Thu, 10 Sep 2020 21:45:08 -0700 (PDT) Received: from dc803.localdomain (FL1-111-169-191-163.hyg.mesh.ad.jp. [111.169.191.163]) by smtp.gmail.com with ESMTPSA id a23sm543817pgv.86.2020.09.10.21.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 21:45:08 -0700 (PDT) From: Tetsuhiro Kohada To: kohada.t2@gmail.com Cc: kohada.tetsuhiro@dc.mitsubishielectric.co.jp, mori.takahiro@ab.mitsubishielectric.co.jp, motai.hirotaka@aj.mitsubishielectric.co.jp, Namjae Jeon , Sungjong Seo , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] exfat: remove useless check in exfat_move_file() Date: Fri, 11 Sep 2020 13:45:06 +0900 Message-Id: <20200911044506.13912-1-kohada.t2@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In exfat_move_file(), the identity of source and target directory has been checked by the caller. Also, it gets stream.start_clu from file dir-entry, which is an invalid determination. Signed-off-by: Tetsuhiro Kohada --- fs/exfat/namei.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index 803748946ddb..1c433491f771 100644 --- a/fs/exfat/namei.c +++ b/fs/exfat/namei.c @@ -1095,11 +1095,6 @@ static int exfat_move_file(struct inode *inode, struct exfat_chain *p_olddir, if (!epmov) return -EIO; - /* check if the source and target directory is the same */ - if (exfat_get_entry_type(epmov) == TYPE_DIR && - le32_to_cpu(epmov->dentry.stream.start_clu) == p_newdir->dir) - return -EINVAL; - num_old_entries = exfat_count_ext_entries(sb, p_olddir, oldentry, epmov); if (num_old_entries < 0) -- 2.25.1