From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Changki Kim <changki.kim@samsung.com>,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
changbin.du@intel.com, masahiroy@kernel.org, rd.dunlap@gmail.com,
gregkh@linuxfoundation.org, krzk@kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [POC] printk: Convert dict ring into array
Date: Fri, 11 Sep 2020 12:32:17 +0200 [thread overview]
Message-ID: <20200911103217.GJ3864@alley> (raw)
In-Reply-To: <20200911095035.GI3864@alley>
On Fri 2020-09-11 11:50:35, Petr Mladek wrote:
> This is POC how the printk() code would look when dict ring
> gets converted into an array of extended info structures.
>
> It applies on top of the patchset ("[PATCH printk v4 0/6]
> printk: reimplement LOG_CONT handling"), see
> https://lore.kernel.org/r/20200908202859.2736-1-john.ogness@linutronix.de
>
> It compiles and even seems to work. But it would need quite
> some love and discussion to get ready for merging.
[...]
> Well, there is only small step to bundle these values into the existing
> struct printk_info.
My opinion:
I would like to go this way in the long term because it looks like the most
easy and reliable solution. But I do _not_ want to block pushing printk
rework [0][1] into mainline because of this.
Handling more information for each stored message is tangential to the
printk rework. It would make it easier for crashdump related tools
when the log buffer format is not modified many times. But it
might block the rework indefinitely.
The lockless ringbuffer is almost ready for merging into mainline.
It will be a huge change on its own. The printk rework is very
important effort. It is cleaning up the printk design and
helps with many historical problems, like deadlocks or soft-lockups.
I do not want to complicate it much more with adding more meta
information and yet another format change that would deserve
more investigation and discussion.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/log/?h=printk-rework
[1] https://lore.kernel.org/r/20200908202859.2736-1-john.ogness@linutronix.de
Best Regards,
Petr
next prev parent reply other threads:[~2020-09-11 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200904082449epcas2p4420d5df2083325b328a182c79f5c0948@epcas2p4.samsung.com>
2020-09-04 8:24 ` printk: Add process name information to printk() output Changki Kim
2020-09-04 9:05 ` Greg KH
2020-09-04 9:31 ` 김창기
2020-09-04 10:34 ` 'Greg KH'
2020-09-07 1:48 ` 김창기
2020-09-04 9:47 ` John Ogness
2020-09-04 10:35 ` Greg KH
2020-09-04 19:27 ` Joe Perches
2020-09-04 12:45 ` Petr Mladek
2020-09-04 13:17 ` John Ogness
2020-09-04 15:13 ` Petr Mladek
2020-09-04 23:27 ` John Ogness
2020-09-07 9:28 ` 김창기
2020-09-07 9:54 ` Petr Mladek
2020-09-07 10:30 ` John Ogness
2020-09-07 15:47 ` Petr Mladek
2020-09-11 9:50 ` [POC] printk: Convert dict ring into array Petr Mladek
2020-09-11 10:32 ` Petr Mladek [this message]
2020-09-11 11:09 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911103217.GJ3864@alley \
--to=pmladek@suse.com \
--cc=changbin.du@intel.com \
--cc=changki.kim@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rd.dunlap@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®