From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F55FC433E2 for ; Sun, 13 Sep 2020 21:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 516B3221EF for ; Sun, 13 Sep 2020 21:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726024AbgIMVob (ORCPT ); Sun, 13 Sep 2020 17:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgIMVo3 (ORCPT ); Sun, 13 Sep 2020 17:44:29 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5171C06174A; Sun, 13 Sep 2020 14:44:28 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B89A212823AA7; Sun, 13 Sep 2020 14:27:40 -0700 (PDT) Date: Sun, 13 Sep 2020 14:44:27 -0700 (PDT) Message-Id: <20200913.144427.302590505192650163.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: kuba@kernel.org, mhabets@solarflare.com, arnd@arndb.de, hkallweit1@gmail.com, mdf@kernel.org, mst@redhat.com, vaibhavgupta40@gmail.com, leon@kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] tulip: de2104x: switch from 'pci_' to 'dma_' API From: David Miller In-Reply-To: <20200913124453.355542-1-christophe.jaillet@wanadoo.fr> References: <20200913124453.355542-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sun, 13 Sep 2020 14:27:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Sun, 13 Sep 2020 14:44:53 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'de_alloc_rings()' GFP_KERNEL can be used > because it is only called from 'de_open()' which is a '.ndo_open' > function. Such functions are synchronized using the rtnl_lock() semaphore > and no lock is taken in the between. ... > Signed-off-by: Christophe JAILLET Applied.