mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ludwig Zenz <lzenz@dh-electronics.com>
To: <alain.volmat@st.com>
Cc: <alexandre.torgue@st.com>, <amelie.delaunay@st.com>,
	<broonie@kernel.org>, <fabrice.gasnier@st.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<mcoquelin.stm32@gmail.com>, <marex@denx.de>
Subject: [PATCH v2 2/5] spi: stm32: fix fifo threshold level in case of short transfer
Date: Mon, 14 Sep 2020 12:33:00 +0200	[thread overview]
Message-ID: <20200914103300.5832-1-lzenz@dh-electronics.com> (raw)
In-Reply-To: <1597043558-29668-3-git-send-email-alain.volmat@st.com>

> When transfer is shorter than half of the fifo, set the data packet size
> up to transfer size instead of up to half of the fifo.
> Check also that threshold is set at least to 1 data frame.

Through a git-bisect we have identified this patch as problematic. We have an application that uses a SPI protocol with telegrams of length 2 to 16 bytes. Due to this patch we have errors in the data transfer of the MOSI direction. We use SPI in PIO mode.

Please explain what this patch should improve or what exactly is changed in the behaviour.

best regards,
Ludwig Zenz

  reply	other threads:[~2020-09-14 10:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10  7:12 [PATCH v2 0/5] spi: stm32: various driver fixes Alain Volmat
2020-08-10  7:12 ` [PATCH v2 1/5] spi: stm32h7: fix race condition at end of transfer Alain Volmat
2020-08-10  7:12 ` [PATCH v2 2/5] spi: stm32: fix fifo threshold level in case of short transfer Alain Volmat
2020-09-14 10:33   ` Ludwig Zenz [this message]
2020-08-10  7:12 ` [PATCH v2 3/5] spi: stm32: fix stm32_spi_prepare_mbr in case of odd clk_rate Alain Volmat
2020-08-10  7:12 ` [PATCH v2 4/5] spi: stm32: fixes suspend/resume management Alain Volmat
2020-08-10  7:12 ` [PATCH v2 5/5] spi: stm32: always perform registers configuration prior to transfer Alain Volmat
2020-08-10 18:58 ` [PATCH v2 0/5] spi: stm32: various driver fixes Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914103300.5832-1-lzenz@dh-electronics.com \
    --to=lzenz@dh-electronics.com \
    --cc=alain.volmat@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=amelie.delaunay@st.com \
    --cc=broonie@kernel.org \
    --cc=fabrice.gasnier@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®